refactor, qt: Nuke some circular dependencies #17513

1. 
   hebasto commented at 10:21 am on November 19, 2019: member

   This PR gets rid of the following circular dependencies:

   • qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/guiutil
   • qt/walletmodel -> qt/walletmodeltransaction -> qt/walletmodel
   • qt/paymentserver -> qt/walletmodel -> qt/paymentserver
2. 
   practicalswift commented at 10:23 am on November 19, 2019: contributor

   Concept ACK

   Wow, three nuked circular dependencies in one go! Feels very good to see this suppression list shrink :)

3. fanquake added the label GUI on Nov 19, 2019
4. fanquake added the label Refactoring on Nov 19, 2019
5. hebasto force-pushed on Nov 19, 2019
6. 
   DrahtBot commented at 11:45 am on November 19, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17492 (QT: bump fee returns PSBT on clipboard for watchonly-only wallets by instagibbs)
   • #17477 (Remove the mempool’s NotifyEntryAdded and NotifyEntryRemoved signals by jnewbery)
   • #15987 (Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr)
   • #14384 (Fire TransactionRemovedFromMempool callbacks from mempool by l2a5b1)
   • #10785 (Serialization improvements by sipa)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. hebasto force-pushed on Nov 19, 2019
8. hebasto force-pushed on Nov 19, 2019
9. 
   instagibbs commented at 2:29 pm on November 19, 2019: member

   literally did a subset of this for #17492

   concept ACK

10. 
    hebasto commented at 2:49 pm on November 19, 2019: member

    @instagibbs

    literally did a subset of this for #17492

    Oh, I didn’t notice 450a2f7913bfbcfbc9c9dcc03c468043fe86fd76 before…

11. 
    instagibbs commented at 2:54 pm on November 19, 2019: member

    I was later pretty sure, just noting this would help my PR get smaller :)
12. refactor: Move SendCoinsRecipient in own header

    Co-authored-by: Gregory Sanders <gsanders87@gmail.com>

    73b5505cfe
13. refactor: Nuke walletmodel circular dependency a53e9895db
14. refactor: Cleanup headers from walletmodel.h 5f50599ae7
15. refactor: Nuke guiutil circular dependency

    Co-authored-by: Gregory Sanders <gsanders87@gmail.com>

    567cb44eb9
16. refactor: Nuke walletmodeltransaction circular dep 49c4211c04
17. hebasto force-pushed on Nov 19, 2019
18. 
    hebasto commented at 3:12 pm on November 19, 2019: member

    @instagibbs has been added as a co-author.
19. 
    Sjors commented at 6:54 pm on November 19, 2019: member

    ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a
20. 
    instagibbs commented at 7:05 pm on November 20, 2019: member

    code review ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a
21. 
    practicalswift commented at 9:21 pm on November 20, 2019: contributor

    ACK 567cb44eb95785c8df93a3844207d17f4c390372 – diff looks correct
22. 
    hebasto commented at 10:26 am on November 21, 2019: member

    @practicalswift

    ACK 567cb44 – diff looks correct

    You’ve ACKed non-top commit ;)

23. promag approved
24. 
    promag commented at 11:05 am on November 21, 2019: member

    ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a.
25. 
    practicalswift commented at 11:22 am on November 21, 2019: contributor

    @hebasto Oh, thanks!

    ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a – diff looks correct

26. laanwj referenced this in commit 69a6f1ad1f on Nov 21, 2019
27. laanwj merged this on Nov 21, 2019
28. laanwj closed this on Nov 21, 2019

    ---

29. hebasto deleted the branch on Nov 21, 2019
30. sidhujag referenced this in commit 4d4df20bd4 on Nov 22, 2019
31. MarkLTZ referenced this in commit cb1ab2aba6 on Nov 29, 2019
32. jasonbcox referenced this in commit 185ad49feb on Oct 1, 2020
33. deadalnix referenced this in commit 8f8f44c456 on Oct 1, 2020
34. deadalnix referenced this in commit 4ff5a135d0 on Oct 1, 2020
35. sidhujag referenced this in commit 0f0fd86fc8 on Nov 10, 2020
36. MarcoFalke locked this on Dec 16, 2021

Contributors
hebasto practicalswift DrahtBot instagibbs Sjors promag

Labels
GUI Refactoring