This PR gets rid of the following circular dependencies:
qt/guiutil->qt/walletmodel->qt/optionsmodel->qt/guiutilqt/walletmodel->qt/walletmodeltransaction->qt/walletmodelqt/paymentserver->qt/walletmodel->qt/paymentserver
refactor, qt: Nuke some circular dependencies #17513
pull hebasto wants to merge 5 commits into bitcoin:master from hebasto:20191119-nuke-circular-dep changing 17 files +109 −73-
hebasto commented at 10:21 AM on November 19, 2019: member
-
practicalswift commented at 10:23 AM on November 19, 2019: contributor
Concept ACK
Wow, three nuked circular dependencies in one go! Feels very good to see this suppression list shrink :)
- fanquake added the label GUI on Nov 19, 2019
- fanquake added the label Refactoring on Nov 19, 2019
- hebasto force-pushed on Nov 19, 2019
-
DrahtBot commented at 11:45 AM on November 19, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #17492 (QT: bump fee returns PSBT on clipboard for watchonly-only wallets by instagibbs)
- #17477 (Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals by jnewbery)
- #15987 (Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr)
- #14384 (Fire TransactionRemovedFromMempool callbacks from mempool by l2a5b1)
- #10785 (Serialization improvements by sipa)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- hebasto force-pushed on Nov 19, 2019
- hebasto force-pushed on Nov 19, 2019
-
instagibbs commented at 2:29 PM on November 19, 2019: member
literally did a subset of this for #17492
concept ACK
-
-
instagibbs commented at 2:54 PM on November 19, 2019: member
I was later pretty sure, just noting this would help my PR get smaller :)
-
73b5505cfe
refactor: Move SendCoinsRecipient in own header
Co-authored-by: Gregory Sanders <gsanders87@gmail.com>
-
refactor: Nuke walletmodel circular dependency a53e9895db
-
refactor: Cleanup headers from walletmodel.h 5f50599ae7
-
567cb44eb9
refactor: Nuke guiutil circular dependency
Co-authored-by: Gregory Sanders <gsanders87@gmail.com>
-
refactor: Nuke walletmodeltransaction circular dep 49c4211c04
- hebasto force-pushed on Nov 19, 2019
-
hebasto commented at 3:12 PM on November 19, 2019: member
@instagibbs has been added as a co-author.
-
Sjors commented at 6:54 PM on November 19, 2019: member
ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a
-
instagibbs commented at 7:05 PM on November 20, 2019: member
code review ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a
-
practicalswift commented at 9:21 PM on November 20, 2019: contributor
ACK 567cb44eb95785c8df93a3844207d17f4c390372 -- diff looks correct
-
hebasto commented at 10:26 AM on November 21, 2019: member
- promag approved
-
promag commented at 11:05 AM on November 21, 2019: member
ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a.
-
practicalswift commented at 11:22 AM on November 21, 2019: contributor
@hebasto Oh, thanks!
ACK 5f50599ae7077ae9b9b56edb8892387b6ddc460a -- diff looks correct
- laanwj referenced this in commit 69a6f1ad1f on Nov 21, 2019
- laanwj merged this on Nov 21, 2019
- laanwj closed this on Nov 21, 2019
- hebasto deleted the branch on Nov 21, 2019
- sidhujag referenced this in commit 4d4df20bd4 on Nov 22, 2019
- MarkLTZ referenced this in commit cb1ab2aba6 on Nov 29, 2019
- jasonbcox referenced this in commit 185ad49feb on Oct 1, 2020
- deadalnix referenced this in commit 8f8f44c456 on Oct 1, 2020
- deadalnix referenced this in commit 4ff5a135d0 on Oct 1, 2020
- sidhujag referenced this in commit 0f0fd86fc8 on Nov 10, 2020
- MarcoFalke locked this on Dec 16, 2021
Labels