depends: only use D-Bus with Qt on linux #17521

fanquake commented at 6:37 PM on November 19, 2019: member

Since #8210 we've been passing -dbus-runtime when configuring Qt, however D-Bus isn't used on macOS or Windows. So rather than blanket passing -dbus-runtime, only use D-Bus when building for linux, and disable it for Windows and macOS. This also saves some time building qt in depends (for windows or macOS).

This gist contains a diff of the symbols in a macOS bitcoin-qt after applying this change: https://gist.github.com/fanquake/317e5c9c7d1b5e37a0c1ce8001af18c4.

fanquake added the label Build system on Nov 19, 2019

fanquake added the label Needs gitian build on Nov 19, 2019

fanquake requested review from dongcarl on Nov 19, 2019

hebasto commented at 7:15 PM on November 19, 2019: member

Concept ACK

laanwj commented at 8:30 AM on November 20, 2019: member

Concept ACK.

Not even all Linux kernel-using OSes use D-bus, could also disable it for Android.

DrahtBot commented at 12:30 PM on November 20, 2019: member

Gitian builds

File	commit b4a1da9ef8e4b673c290d5b882527e627ae1b43a<br>(master)	commit fa93a17647ca277f0151d07f8d2dfd95dc8353f3<br>(master and this pull)
bitcoin-0.19.99-osx-unsigned.dmg	`2aac9afb80675e6b...`	`fc2ae7baf88652a6...`
bitcoin-0.19.99-osx64.tar.gz	`fca5c093497da768...`	`2c1ad9e17c853e33...`
bitcoin-0.19.99-win64-debug.zip	`7a0b53fcba538c85...`	`a4244e9620624cc2...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`0dcf41e68351b5d3...`	`60bde2c9b2decf62...`
bitcoin-0.19.99-win64.zip	`c8d229696feb714f...`	`733677bdfda23227...`
bitcoin-0.19.99.tar.gz	`0fbc1c4e20f88988...`	`e5804cf22a4acfd9...`
bitcoin-core-osx-0.20-res.yml	`a1bd02b0758e2e04...`	`62e3d678f9306b11...`
bitcoin-core-win-0.20-res.yml	`6dba0dd84407549e...`	`bba6babed6d4a831...`
linux-build.log	`d1ee3974fc3a4437...`	`30d703d7b3e8258d...`
osx-build.log	`0ea76b9d6b91529b...`	`ea088208653e1754...`
win-build.log	`c66e143a3b0cf570...`	`784deb926028deb9...`
bitcoin-core-osx-0.20-res.yml.diff		`671ba16e3ed16a09...`
bitcoin-core-win-0.20-res.yml.diff		`ceec0b22ca9d16f2...`
linux-build.log.diff		`932a125cf2eef362...`
osx-build.log.diff		`52196f9e4cf2321c...`
win-build.log.diff		`ab44643aa9da138e...`

DrahtBot removed the label Needs gitian build on Nov 20, 2019

depends: only use dbus with qt on linux 6fdf5dab26

fanquake force-pushed on Nov 20, 2019

fanquake commented at 3:32 PM on November 20, 2019: member

could also disable it for Android.

Done.

MarcoFalke added the label Needs gitian build on Nov 25, 2019

DrahtBot commented at 3:18 PM on November 27, 2019: member

Gitian builds

File	commit 2c1c43754b7a29e2fc852c2ad6430ba27aa2d7db<br>(master)	commit e9bb45a61e050c51dd0df07aa29f874de2fd659c<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`38cbfb45b6a7086d...`	`3c2fff5ab701f6e1...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`da5cf67a007aed08...`	`ac700c49e874fbac...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`184e8ce64969a801...`	`fce07079bbb8a342...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`281f743a1af9f788...`	`2a7a9dac254f4cf5...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`094e8232c0b5fc1e...`	`e002c9170c883bc0...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`ab4deb19e22c2e9c...`	`8ea563f9dc622fc0...`
bitcoin-0.19.99-osx-unsigned.dmg	`bd9ae85f63baebb0...`	`5b1829bafe4c0750...`
bitcoin-0.19.99-osx64.tar.gz	`61305776c2b32f02...`	`db46c8e659795bf8...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`9c9b077e4c62ca11...`	`3c3faeb9bdc35e3d...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`b33148372a530635...`	`5467d251ba2ea1f5...`
bitcoin-0.19.99-win64-debug.zip	`20a7fd94fde51027...`	`a378deeabfed0c16...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`94be28f0f2a7d072...`	`630bf709df4ef445...`
bitcoin-0.19.99-win64.zip	`77303c3b0e4d270b...`	`6b8b241ed1b962f8...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`41dec10c82bf5058...`	`6ceb63063666c627...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`ee561a8a74b45caa...`	`fcf5653dd5ae474c...`
bitcoin-0.19.99.tar.gz	`a2c202a483d1f9e1...`	`fd8f5d3a25e881bf...`
bitcoin-core-linux-0.20-res.yml	`5d71778589f1dbbe...`	`a6e7a2989f376cb2...`
bitcoin-core-osx-0.20-res.yml	`fefe01def2f61fe3...`	`28e5b9fb1f2a7cf7...`
bitcoin-core-win-0.20-res.yml	`c6d1798223f3d9aa...`	`dfc22dd9f195c329...`
linux-build.log	`7babaa31c8e7e008...`	`317eff41d11fbf5a...`
osx-build.log	`44cec8cec24a7204...`	`b19b81b27e5ce73a...`
win-build.log	`11636a6fb5df52aa...`	`aca821ed16e871d6...`
bitcoin-core-linux-0.20-res.yml.diff		`9d905377d5658572...`
bitcoin-core-osx-0.20-res.yml.diff		`9525afc10d2db541...`
bitcoin-core-win-0.20-res.yml.diff		`2a6d1e3b0faec156...`
linux-build.log.diff		`77d2a85588c5cb47...`
osx-build.log.diff		`3edf455fcffb53c6...`
win-build.log.diff		`711f063e9074febd...`

DrahtBot removed the label Needs gitian build on Nov 27, 2019

laanwj commented at 10:50 AM on November 28, 2019: member

ACK 6fdf5dab26e87888c3511fecef5d4d612b8247d6

fanquake commented at 2:07 PM on November 28, 2019: member

Note that this also reduces the macOS bitcoin-qt size by ~1.5% when I compare with a depends built master (114e89e596a66f3cb1ebd8fc2d775b61c5722245). 29798952 bytes vs 29373472.

fanquake referenced this in commit 2ecb7e1556 on Dec 1, 2019

fanquake merged this on Dec 1, 2019

fanquake closed this on Dec 1, 2019

fanquake deleted the branch on Dec 1, 2019

sidhujag referenced this in commit bff238f819 on Dec 1, 2019

deadalnix referenced this in commit e9dd003a97 on Apr 8, 2020

ftrader referenced this in commit 7c13da4b1a on Aug 17, 2020

sidhujag referenced this in commit 528732538c on Nov 10, 2020

MarcoFalke locked this on Dec 16, 2021