Bump minimum libc to 2.19 for release binaries #17531

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2019_11_bump_libc changing 1 files +15 −15
  1. laanwj commented at 10:02 am on November 20, 2019: member

    Fixes #17525.

    Debian 8 (Jessie, oldoldstable) has:

    Debian 9 (Stretch, Oldstable) has:

    Ubuntu 16.04.4 (Xenial, oldest supported Ubuntu) has:

    Taking the minimum of these as our target.

    According to GNU ABI document (http://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html) this corresponds to:

    • GCC 4.9.2: GCC_4.8.0
    • (glibc) GLIBC_2_19

    This also contains a (long needed) commit to disallow dynamic linking to stdc++, as our releases statically link against that.

    It might be possible to remove some fallbacks from src/compat/glibc_compat.cpp, too. But I’ll wait for the version decision first.

  2. build: Disallow dynamic linking against c++ library 
    Ever since statically linking Qt, we've been linking the C++ library
statically too (-static-libstdc++). Take this into
account in the symbol checker.
    560f440597
  3. laanwj added the label Build system on Nov 20, 2019
  4. laanwj added the label Needs release note on Nov 20, 2019
  5. laanwj added this to the milestone 0.20.0 on Nov 20, 2019
  6. laanwj commented at 10:06 am on November 20, 2019: member

    Could also do Debian 8 (Jessie, oldoldstable):

    Which would be:

    • GCC 4.9.2: GCC_4.8.0
    • (glibc) GLIBC_2_19

    This would still fix #17525, which requires at least 2.16.

  7. laanwj force-pushed on Nov 20, 2019
  8. laanwj renamed this:
    Bump minimum libc version to 2.23
    Bump minimum libc to 2.23 for release binaries
    on Nov 20, 2019
  9. fanquake commented at 11:56 am on November 20, 2019: member
    Concept ACK
  10. build: Bump minimum versions in symbol checker 
    Debian 8 (Jessie) has:

- g++ version 4.9.2 (https://packages.debian.org/search?suite=jessie&arch=any&searchon=names&keywords=g%2B%2B)
- libc version 2.19 (https://packages.debian.org/search?suite=jessie&arch=any&searchon=names&keywords=libc6)

Ubuntu 16.04.4 (Xenial) has:

- g++ version 5.3.1 (https://packages.ubuntu.com/search?keywords=g%2B%2B&searchon=names&suite=xenial&section=all)
- libc version 2.23.0 (https://packages.ubuntu.com/search?keywords=libc6&searchon=names&suite=xenial&section=all)

Taking the minimum of these as our target.

According to GNU ABI document (http://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html) this corresponds to:

- GCC 4.9.2: GCC_4.8.0
- (glibc)    GLIBC_2_19
    ad4dcb0870
  11. laanwj force-pushed on Nov 20, 2019
  12. laanwj renamed this:
    Bump minimum libc to 2.23 for release binaries
    Bump minimum libc to 2.19 for release binaries
    on Nov 20, 2019
  13. laanwj commented at 12:18 pm on November 20, 2019: member
    I have backed this down to 2.19 (Debian Stretch/Oldoldstable). I see no reason to push for anything higher. Should be uncontroversial now.
  14. laanwj added the label Needs gitian build on Nov 20, 2019
  16. laanwj commented at 12:46 pm on November 20, 2019: member
    Bah, I’m giving up on this.
  17. laanwj closed this on Nov 20, 2019
  18. MarcoFalke removed the label Needs gitian build on Nov 20, 2019
  19. MarcoFalke commented at 12:56 pm on November 20, 2019: member

    Could also add the EOL in comments, so:

  20. laanwj commented at 12:58 pm on November 20, 2019: member
    Feel free to pick this up, I don’t feel like bothering with the eternal pit of misery that is distributing binaries for Linux anymore.
  21. MarcoFalke added the label Up for grabs on Nov 20, 2019
  22. fanquake removed the label Up for grabs on Nov 20, 2019
  23. fanquake commented at 3:43 pm on November 20, 2019: member
    I’ll grab this.
  24. MarcoFalke referenced this in commit 7463181798 on Nov 24, 2019
  25. sidhujag referenced this in commit d8d6e00d8d on Nov 25, 2019
  26. fanquake removed the label Needs release note on Nov 27, 2019
  27. sidhujag referenced this in commit 6a9f836f72 on Nov 10, 2020
  28. UdjinM6 referenced this in commit a9c8a3d221 on Aug 30, 2021
  29. MarcoFalke locked this on Dec 16, 2021


laanwj fanquake MarcoFalke

Labels
Build system

Milestone
0.20.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 22:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me