ci: misc cleanups #17549

pull MarcoFalke wants to merge 5 commits into bitcoin:master from MarcoFalke:1911-ciCleanups changing 8 files +35 −78

MarcoFalke commented at 4:10 PM on November 21, 2019: member
Some minor cleanups:
- Remove unused and unmaintained extended_lint to avoid ci bottlenecks and waste of CPU
- Move all folders that hold temporary ci files to the ci scratch dir (except for the build dirs)
- Add some documentation to folders and remove the BASE_BUILD_DIR alias for the root directory
- Fixes #17178 by removing cd

scripted-diff: Move various folders to ci scratch dir

-BEGIN VERIFY SCRIPT-
 # move ci sanitizer-output
 sed -i -e 's|BASE_BUILD_DIR}/sanitizer-output|BASE_SCRATCH_DIR}/sanitizer-output|g' $(git grep -l BASE_BUILD_DIR ci)
 # move qa-assets
 sed -i -e 's|BASE_BUILD_DIR}/qa-assets|BASE_SCRATCH_DIR}/qa-assets|g'               $(git grep -l BASE_BUILD_DIR ci)
 # move out dir
 sed -i -e 's|BASE_BUILD_DIR/out|BASE_SCRATCH_DIR/out|g'                             $(git grep -l BASE_BUILD_DIR ci)
-END VERIFY SCRIPT-

faeeca87b6

ci: Add DEPENDS_DIR variable, Add documentation for folders fa0656d1eb

scripted-diff: Use ci DEPENDS_DIR, remove BASE_BUILD_DIR

-BEGIN VERIFY SCRIPT-
 # Use ci DEPENDS_DIR
 sed -i -e 's|BASE_BUILD_DIR/depends|DEPENDS_DIR|g' $(git grep -l depends ci)
 sed -i -e 's| depends/| ${DEPENDS_DIR}/|g'         $(git grep -l depends ci)

 # Remove redundant alias
 sed -i -e 's|BASE_BUILD_DIR|BASE_ROOT_DIR|g'       $(git grep -l BASE_BUILD_DIR ci)
-END VERIFY SCRIPT-

fa04187528

ci: Remove unmaintained extended_lint fa2941bbf4
MarcoFalke added the label Tests on Nov 21, 2019
DrahtBot commented at 12:47 AM on November 22, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17517 (ci: Bump to clang-8 for asan build to avoid segfaults on ppc64le by MarcoFalke)
- #12134 (Build previous releases and run functional tests by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ci: Remove use of cd fad88e6f86
MarcoFalke referenced this in commit 1705f1949a on Dec 3, 2019
MarcoFalke merged this on Dec 3, 2019
MarcoFalke closed this on Dec 3, 2019
sidhujag referenced this in commit ae04887b37 on Dec 3, 2019
MarcoFalke deleted the branch on Dec 5, 2019
sidhujag referenced this in commit c2eb451354 on Nov 10, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

MarcoFalke

DrahtBot

Labels

Tests

Linked (view graph)

#17178 test: Debug travis macOS environment #25091 test: Remove extended lint (cppcheck)

ci: misc cleanups #17549

Conflicts