build: set minimum supported macOS to 10.12

fanquake commented at 4:30 pm on November 21, 2019: member

Extracted from #16392 as this doesn’t need to wait for the other build changes.

Reasoning:

10.10 has been unsupported since July 2017 (~3 years at v0.20.0 release)
10.11 has been unsupported since July 2018 (~2 years at v0.20.0 release)
macOS users are consistent at upgrading to new releases.
Qt 5.12 LTS only supports macOS > 10.12. As long as we’re supporting macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the v0.20.0 release.

Once we drop support for 10.12 and start using the 10.15 SDK there are some other follow ups:

Enabling support for thread_local.
Removing some of the macOS notification code
Removing macOS startup item code.

There was also some related discussion in the #bitcoin-builds channel yesterday arvo.

build: set minimum supported macOS to 10.12 7d7bf2ff4a

fanquake added the label macOS on Nov 21, 2019

fanquake added the label Build system on Nov 21, 2019

MarcoFalke added the label Needs gitian build on Nov 21, 2019

DrahtBot commented at 6:04 pm on November 21, 2019: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17558 (build: organize tests by goal by RandyMcMillan)
#17099 (depends: Eliminate hard dependency on Ubuntu-ABI specific clang by dongcarl)
#16392 (build: macOS toolchain update by fanquake)
#12557 ([WIP] 64 bit iOS device support by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

MarcoFalke approved

DrahtBot commented at 2:35 am on November 22, 2019: member

Gitian builds

File	commit ae6943620ab369e8e0865c3ec2d2848ba9389325(master)	commit 0378a9d9c4ea8d1ad57782bcfec78d52ab1f4f5e(master and this pull)
bitcoin-0.19.99-osx-unsigned.dmg	`a7077050e4e2bed9...`	`7dfca23b6cd1426b...`
bitcoin-0.19.99-osx64.tar.gz	`b8bddf81623819d9...`	`24fe8f3d6df1d254...`
bitcoin-0.19.99-win64-debug.zip	`222ac303e7213421...`	`a2361870d818adaf...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`f924c6a25deb4fe0...`	`4f8aa9d39708ca88...`
bitcoin-0.19.99-win64.zip	`bc4bd2e95d543f51...`	`621d8c992e81991e...`
bitcoin-0.19.99.tar.gz	`758ae50b9c3a4da5...`	`88dd5b04c3a05b62...`
bitcoin-core-osx-0.20-res.yml	`111f0057f97ae6d1...`	`a83a53609bd8423c...`
bitcoin-core-win-0.20-res.yml	`dcf3b20a7eed8d5a...`	`075c2a1cc31e28a1...`
linux-build.log	`6cf45344f07c50f6...`	`5f1607ce41b0b8ae...`
osx-build.log	`34aae11122a92ea9...`	`d9e3ec24998793ce...`
win-build.log	`129e7447b12a2ac4...`	`ba706f5142ef5355...`
bitcoin-core-osx-0.20-res.yml.diff		`7c96d905cbbfe621...`
bitcoin-core-win-0.20-res.yml.diff		`dadf77bd87ce5ca0...`
linux-build.log.diff		`80b1343d123a64ab...`
osx-build.log.diff		`084846f457a20d54...`
win-build.log.diff		`02649eebf38a0375...`

DrahtBot removed the label Needs gitian build on Nov 22, 2019

laanwj commented at 8:31 am on November 22, 2019: member

ACK 7d7bf2ff4a67c3953b0d660ca88d11313cb4d71d

MarcoFalke added the label Needs gitian build on Nov 22, 2019

dongcarl commented at 4:22 pm on November 22, 2019: member

So this bumps the supported OSX version, but doesn’t bump the SDK? (At least not a major version of the SDK?)

Edit: What I’m trying to ask is, could we have bumped the supported OSX version without bumping the SDK?

fanquake commented at 4:45 pm on November 22, 2019: member

could we have bumped the supported OSX version without bumping the SDK

That’s what this PR is doing. This increases our minimum supported macOS version from 10.10 to 10.12. Nothing SDK related is changing, the change to start using the 10.14 SDK over the 10.11 SDK is still in #16392.

dongcarl commented at 5:00 pm on November 22, 2019: member

post-IRC-grilling-ACK 7d7bf2ff4a67c3953b0d660ca88d11313cb4d71d

See http://gnusha.org/bitcoin-builds/2019-11-22.log

fanquake referenced this in commit a6f5b6f47d on Nov 22, 2019

fanquake merged this on Nov 22, 2019

fanquake closed this on Nov 22, 2019

fanquake deleted the branch on Nov 22, 2019

sidhujag referenced this in commit 016b46aabb on Nov 22, 2019

DrahtBot commented at 10:22 pm on November 22, 2019: member

Gitian builds

File	commit 03f6f408ab2e9b30e1ee747b76bd9edc20b2c99d(master)	commit a871199c81b927bf67b5db8236db63352bfeb23f(master and this pull)
bitcoin-0.19.99-osx-unsigned.dmg	`0c1faf592001a4bc...`	`14c86c654773a234...`
bitcoin-0.19.99-osx64.tar.gz	`1802721036ef4368...`	`17e3fc51fd131721...`
bitcoin-0.19.99-win64-debug.zip	`849a34a9b645e1c8...`	`5b164d8c0d1a7bf7...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`0d302fe511dbe175...`	`f77c950fb0ca7b6c...`
bitcoin-0.19.99-win64.zip	`a406548e44896849...`	`d93d7ce13f02835c...`
bitcoin-0.19.99.tar.gz	`569f33ef5ea223d2...`	`5a653c86a4de54d8...`
bitcoin-core-osx-0.20-res.yml	`585f6e1c23d5bc1a...`	`b6d79cf77133f80e...`
bitcoin-core-win-0.20-res.yml	`04e71aa86e9740e6...`	`388e6b762624d79f...`
linux-build.log	`33e4113947a45350...`	`25f1a916e4a97572...`
osx-build.log	`62d5264be52cd130...`	`51d6e22f9f321bf6...`
win-build.log	`901967e161ef3d60...`	`565c4236d457b63c...`
bitcoin-core-osx-0.20-res.yml.diff		`351556ba8317d4e4...`
bitcoin-core-win-0.20-res.yml.diff		`3debf004ba9a5b47...`
linux-build.log.diff		`ad657631442dad74...`
osx-build.log.diff		`2ea06ae8d37f68a3...`
win-build.log.diff		`de8a2c5f9169ac4e...`

DrahtBot removed the label Needs gitian build on Nov 22, 2019

fanquake referenced this in commit 27d82b63fb on Nov 22, 2019

fanquake referenced this in commit 4fb82e916b on Nov 26, 2019

sidhujag referenced this in commit 04359028bb on Nov 27, 2019

laanwj referenced this in commit 1d64dfe4fa on Mar 17, 2020

sidhujag referenced this in commit db7e54243a on Mar 18, 2020

deadalnix referenced this in commit f7352a1260 on Mar 20, 2020

deadalnix referenced this in commit e509537d3a on Mar 21, 2020

HashUnlimited referenced this in commit e5a4fcad33 on Apr 17, 2020

ftrader referenced this in commit 967f01e046 on May 19, 2020

zkbot referenced this in commit 2a39656e6d on Jul 30, 2020

zkbot referenced this in commit e0692ed4df on Aug 7, 2020

sidhujag referenced this in commit e6a74d1ea3 on Nov 10, 2020

sidhujag referenced this in commit d18a192f24 on Nov 10, 2020

sidhujag referenced this in commit 7f195d3241 on Nov 10, 2020

backpacker69 referenced this in commit ad83e1f997 on Mar 28, 2021

furszy referenced this in commit 816f42d7ac on May 25, 2021

kittywhiskers referenced this in commit da8324f634 on Jul 15, 2021

kittywhiskers referenced this in commit fabdf5d492 on Jul 20, 2021

kittywhiskers referenced this in commit 820f616c55 on Jul 20, 2021

kittywhiskers referenced this in commit 68d875a67d on Jul 20, 2021

kittywhiskers referenced this in commit 25efd59cfa on Aug 1, 2021

kittywhiskers referenced this in commit c298c0247d on Aug 24, 2021

kittywhiskers referenced this in commit d762e1263e on Aug 25, 2021

kittywhiskers referenced this in commit 1949f93748 on Aug 26, 2021

kittywhiskers referenced this in commit 0e1aad5d4b on Aug 27, 2021

kittywhiskers referenced this in commit b09ddbeb97 on Aug 30, 2021

kittywhiskers referenced this in commit ced48380b8 on Aug 31, 2021

DrahtBot locked this on Dec 16, 2021

build: set minimum supported macOS to 10.12 #17550

Conflicts

Gitian builds

Gitian builds