gui: remove macOS start on login code #17567

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_macos_startup_item changing 3 files +3 −87

fanquake commented at 2:07 AM on November 23, 2019: member

The macOS startup item code was disabled for builds targeting macOS > 10.11 in #15208. Now that we require macOS 10.12 as a minimum (#17550), we can remove the startup item code entirely. The API we were using, LSSharedFileListItemCopyResolvedURL, LSSharedFileListCopySnapshot etc, was removed in macOS 10.12 SDK.

gui: remove macOS start on login code

The macOS startup item code was disabled for builds targeting macOS >
10.11 in #15208. Now that we require macOS 10.12 as a minimum, #17550,
we can remove the startup item code entirely, as the API we were using
was removed in macOS 10.12.

27d82b63fb

fanquake added the label GUI on Nov 23, 2019
fanquake added the label macOS on Nov 23, 2019
laanwj commented at 8:45 AM on November 23, 2019: member

ACK.

If someone means to add this functionality again in the future, I think something like #9005 would be required.
in doc/release-notes.md:89 in 27d82b63fb
```
  85 | @@ -86,6 +86,8 @@ Low-level Changes section below.
  86 |  GUI changes
  87 |  -----------
  88 |  
  89 | +- The "Start Bitcoin Core on system login" option has been removed on macOS.
```
laanwj commented at 8:45 AM on November 23, 2019:

Please mention that it was already not working on recent MacOS versions (so effectively this is an user-invisible change).

fanquake commented at 7:19 PM on November 25, 2019:

This change will actually be user facing, as the current release binaries include this option in the preferences menu (0.19 was compiled with a macOS 10.10 minimum and targeting the 10.11 SDK).

laanwj commented at 7:36 PM on November 25, 2019:

So the option was there, but it wasn't working on newer MacOS?

fanquake commented at 7:43 PM on November 25, 2019:

The option was there, and it should have been working for all versions of macOS (I can only test up to 10.14). Note that there are plenty of ways for the user to create the "start at login" behaviour without us providing an option from within Bitcoin Core.

laanwj commented at 9:46 AM on November 26, 2019:

Ok, thanks for explaining.

The way MacOS does things is really confusing here. So we need to remove the functionality because the calls are deprecated, but they still work fine, even on newer MacOS, if compiled with an older MacOS in mind.

Note that there are plenty of ways for the user to create the "start at login" behaviour without us providing an option from within Bitcoin Core.

I remember we used a different way based on scripts in the past. That way was deprecated, too :angry: Although annoying for users which rely on this functionality, I tend to agree it's not worth coming up with a new hack here every time.

DimitarNestorov commented at 4:01 PM on April 12, 2020:

they still work fine, even on newer MacOS, if compiled with an older MacOS in mind

They work just fine even when compiling for the latest macOS
jonasschnelli commented at 6:29 PM on November 23, 2019: contributor

utACK 27d82b63fb8869716d2f103fd381c2413bde4d1b
jonasschnelli commented at 2:22 AM on November 26, 2019: contributor

Tested ACK 27d82b63fb8869716d2f103fd381c2413bde4d1b - successfully compiled on 10.15.1
fanquake referenced this in commit 4fb82e916b on Nov 26, 2019
fanquake merged this on Nov 26, 2019
fanquake closed this on Nov 26, 2019
fanquake deleted the branch on Nov 26, 2019
sidhujag referenced this in commit 04359028bb on Nov 27, 2019
jasonbcox referenced this in commit 945c3d3bc5 on Nov 5, 2020
sidhujag referenced this in commit d18a192f24 on Nov 10, 2020
kittywhiskers referenced this in commit dc4e8e6347 on Jul 15, 2021
kittywhiskers referenced this in commit 59ffe0d0ec on Jul 15, 2021
kittywhiskers referenced this in commit 7783af5429 on Jul 20, 2021
kittywhiskers referenced this in commit f17771eeac on Jul 20, 2021
kittywhiskers referenced this in commit a29e85de0c on Jul 20, 2021
kittywhiskers referenced this in commit f94ff79bf0 on Jul 20, 2021
kittywhiskers referenced this in commit 2d966f5389 on Aug 1, 2021
kittywhiskers referenced this in commit fde9ba192f on Aug 24, 2021
kittywhiskers referenced this in commit c803d2f2bd on Aug 24, 2021
kittywhiskers referenced this in commit 0f68205a6b on Aug 25, 2021
kittywhiskers referenced this in commit 1feb96d1f0 on Aug 26, 2021
kittywhiskers referenced this in commit a3628041cb on Aug 26, 2021
kittywhiskers referenced this in commit 909451fc0b on Aug 27, 2021
kittywhiskers referenced this in commit 5a18de6351 on Aug 30, 2021
kittywhiskers referenced this in commit 2508eaf24e on Aug 31, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#15208 Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement #17550 build: set minimum supported macOS to 10.12