ci: Run functional tests on s390x #17599
pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:1911-ciS390x changing 4 files +7 −8-
MarcoFalke commented at 8:04 pm on November 25, 2019: member
-
MarcoFalke commented at 8:05 pm on November 25, 2019: memberRequested by @sipa here #17591 (comment)
-
fanquake added the label Tests on Nov 25, 2019
-
in ci/test/00_setup_env_s390x.sh:10 in faa8854220 outdated
6@@ -7,12 +7,10 @@ 7 export LC_ALL=C.UTF-8 8 9 export HOST=s390x-unknown-linux-gnu 10-export DOCKER_NAME_TAG=s390x/ubuntu:18.04 11-export PACKAGES="clang llvm python3-zmq qtbase5-dev qttools5-dev-tools libssl1.0-dev libevent-dev bsdmainutils libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev libdb5.3++-dev libminiupnpc-dev libzmq3-dev libqrencode-dev" 12+export DOCKER_NAME_TAG=ubuntu:18.04
MarcoFalke commented at 8:05 pm on November 25, 2019:This is the default, so might as well remove it -
ci: Run functional tests on s390x fa94fc10c8
-
MarcoFalke force-pushed on Nov 25, 2019
-
test: Properly deserialize integers in little-endian fad9fdbea5
-
MarcoFalke commented at 8:28 pm on November 25, 2019: member
Also fixed a bug in the functional tests
See https://docs.python.org/3/library/struct.html#byte-order-size-and-alignment
-
practicalswift commented at 8:41 pm on November 25, 2019: contributor
Concept ACK
Very happy to see this added!
And very satisfying to see that this caught a bug directly :)
-
meshcollider commented at 8:43 pm on November 25, 2019: contributorConcept ACK
-
ci: Print free disk space fabd71076c
-
DrahtBot commented at 9:39 pm on November 25, 2019: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
No conflicts as of last run.
-
laanwj commented at 10:38 am on November 26, 2019: memberACK if it doesn’t make Travis much slower, a bit slower may be worth it to have a full big-endian CI run.
-
MarcoFalke commented at 1:49 pm on November 26, 2019: memberFor some reason this is one of the fastest machines on travis. Installing all packages only took 49 seconds (instead of minutes) and a build from scratch + unit tests + functional tests ran in 15 minutes. I’d argue that we should switch all native builds to run on that architecture instead of amd64.
-
elichai commented at 1:10 pm on November 28, 2019: contributor
@MarcoFalke So apparently I did all that too today lol. But also got the depends to work. So up to you, if you want to cherry pick those / i’ll open another PR or whatever https://github.com/bitcoin/bitcoin/compare/master...elichai:2019-11-s390x
(was just about to open a PR when sipa told me you already did)
-
MarcoFalke commented at 3:35 pm on December 3, 2019: member@elichai Sweet. Looks like you fixed a bug in our depends qt build. So a fresh PR might be the best.
-
MarcoFalke referenced this in commit 69ca6cdd66 on Dec 3, 2019
-
MarcoFalke merged this on Dec 3, 2019
-
MarcoFalke closed this on Dec 3, 2019
-
MarcoFalke deleted the branch on Dec 3, 2019
-
sidhujag referenced this in commit 93458d7c68 on Dec 3, 2019
-
MarcoFalke referenced this in commit a54c16cdb6 on Dec 17, 2019
-
sidhujag referenced this in commit ace53d2e4d on Dec 17, 2019
-
deadalnix referenced this in commit 0511730c0f on Nov 5, 2020
-
sidhujag referenced this in commit 3f44fc7752 on Nov 10, 2020
-
sidhujag referenced this in commit 59e1a5ceb4 on Nov 10, 2020
-
DrahtBot locked this on Dec 16, 2021