qt: Rename intro.* to introdialog.* #17607

1. 
   hebasto commented at 0:47 am on November 26, 2019: member

   … as suggested by qt/README:

   *dialog.(h/cpp) Various dialogs, e.g. to open a URL. Inherit from QDialog.

2. jonasschnelli added the label GUI on Nov 26, 2019
3. 
   laanwj commented at 10:26 am on November 26, 2019: member

   This seems to me to be renaming for the sake of renaming :smile: It’s possible to defend shorter naming (in the absence of ambiguity) as well.

   Doesn’t seem worth keeping a tracking issue open for. I’m not sure why you open this as issue instead of a PR.

4. 
   hebasto commented at 10:03 am on November 27, 2019: member

   @laanwj

   This seems to me to be renaming for the sake of renaming :smile:

   Not at all ;) Objects of QDialog class and its subclasses could spin an additional event loop, that could block the main (GUI) event loop (#17145).

   Following the naming convention, mentioned in OP, makes reasoning about possible the GUI event loop blockers easier.

   I’m not sure why you open this as issue instead of a PR.

   That was a deep night - just have fixed an idea before sleeping ;)

5. 
   laanwj commented at 10:11 am on November 27, 2019: member

   It’s fine, initially this file wasn’t named after any particular class because it contained various utility functions that had to do with initial use of the program. I don’t think this is true anymore.
6. 
   fanquake commented at 1:53 am on February 4, 2020: member

   Doesn’t seem worth keeping a tracking issue open for.

   Agree. Might be addressed in #17611 anyways.

7. fanquake closed this on Feb 4, 2020

   ---

8. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto laanwj fanquake

Labels
GUI