gui: Make send and receive widgets extend QWidget #17611

pull promag wants to merge 2 commits into bitcoin:master from promag:2019-11-send-receive-widgets changing 7 files +11 −11
  1. promag commented at 1:23 pm on November 26, 2019: member
    These aren’t dialogs.
  2. gui: ReceiveCoinsDialog now extends QWidget e5ef90b5f6
  3. gui: SendCoinDialog now extends QWidget 3337c455e0
  4. promag commented at 1:23 pm on November 26, 2019: member
    Let me know if I should include script-diff to rename classes and files.
  5. fanquake added the label GUI on Nov 26, 2019
  6. DrahtBot commented at 6:14 pm on November 26, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18894 (gui: Fix manual coin control with multiple wallets loaded by promag)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. hebasto commented at 11:58 am on November 27, 2019: member

    Concept ACK.

    Let me know if I should include script-diff to rename classes and files.

    I think so.

  8. hebasto commented at 5:45 pm on November 27, 2019: member

    This PR also requires:

    • corresponding changes in forms/*.ui files
    • dropping QDialog slots and signals.
  9. DrahtBot added the label Needs rebase on May 13, 2020
  10. DrahtBot commented at 8:21 am on May 13, 2020: member

    🐙 This pull request conflicts with the target branch and needs rebase.

  11. fanquake commented at 12:38 pm on July 9, 2020: member
    This has a concept ACK, but looks like it may need additional (qt only) changes, conversion to a scripted diff where appropriate and in any case needs a rebase. I’m going to suggest re-opening this in https://github.com/bitcoin-core/gui.
  12. fanquake closed this on Jul 9, 2020

  13. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me