rpc: failure calling dumptxoutset with invalid filename #17612

1. 
   fanquake commented at 2:29 pm on November 26, 2019: member

   0src/bitcoin-cli dumptxoutset utxo.dat/
   1
   2error code: -1
   3error message:
   4CAutoFile::operator<<: file handle is nullptr: unspecified iostream_category error
   

2. fanquake added the label RPC/REST/ZMQ on Nov 26, 2019
3. fanquake added the label good first issue on Nov 26, 2019
4. fanquake renamed this:
   rpc: crash calling dumptxoutset with invalid filename
   rpc: failure calling dumptxoutset with invalid filename
   on Nov 26, 2019
5. 
   brakmic commented at 5:13 pm on November 26, 2019: contributor

   Hi,

   These changes add file name checking via fs::is_regular_file and return proper JSON-errors if not. Functional & Unit Tests introduced as well.

   However, there are other alternatives like boost’s name_check functions, but I think that is_regular_file from C++ std is sufficient enough.

   This of course needs more rigorous checking before opening a PR as I’ve only tested it under macOS Catalina.

   Regards,

6. 
   jamesob commented at 5:23 pm on November 26, 2019: member

   Hi @brakmic. Those changes look good to me! You should just go ahead and open the PR. Thanks for contributing.
7. 
   brakmic commented at 5:48 pm on November 26, 2019: contributor

   Thanks! Ok, then I’ll open a PR!
8. 
   petterhs commented at 5:57 pm on November 26, 2019: none

   Sorry @brakmic. My bad, didn’t see that you had something proposed already. I’ll close it
9. 
   brakmic commented at 5:58 pm on November 26, 2019: contributor

   No problem, @petterhs :) Thanks!
10. 
    brakmic commented at 10:07 pm on November 27, 2019: contributor

    Moved the original PR to https://github.com/bitcoin/bitcoin/pull/17623
11. bitcoin deleted a comment on Jan 4, 2020
12. 
    MarcoFalke commented at 1:50 pm on May 31, 2020: member

    @fanquake Any pointers on how this should be solved? I don’t think this is a bug, but a feature.
13. MarcoFalke removed the label good first issue on Mar 25, 2022
14. 
    MarcoFalke commented at 12:57 pm on March 25, 2022: member

    Is this still an issue with a recent version of Bitcoin Core?
15. 
    fanquake commented at 3:37 pm on August 6, 2022: member

    Happy to close this.
16. fanquake closed this on Aug 6, 2022

    ---

17. bitcoin locked this on Aug 6, 2023

Contributors
fanquake brakmic jamesob petterhs MarcoFalke

Labels
RPC/REST/ZMQ