rpc: failure calling dumptxoutset with invalid filename #17612

issue fanquake opened this issue on November 26, 2019

fanquake commented at 2:29 PM on November 26, 2019: member

src/bitcoin-cli dumptxoutset utxo.dat/

error code: -1
error message:
CAutoFile::operator<<: file handle is nullptr: unspecified iostream_category error

fanquake added the label RPC/REST/ZMQ on Nov 26, 2019
fanquake added the label good first issue on Nov 26, 2019
fanquake renamed this:
~~rpc: crash calling dumptxoutset with invalid filename~~
rpc: failure calling dumptxoutset with invalid filename
on Nov 26, 2019
brakmic commented at 5:13 PM on November 26, 2019: contributor

Hi,

These changes add file name checking via fs::is_regular_file and return proper JSON-errors if not. Functional & Unit Tests introduced as well.

However, there are other alternatives like boost's name_check functions, but I think that is_regular_file from C++ std is sufficient enough.

This of course needs more rigorous checking before opening a PR as I've only tested it under macOS Catalina.

Regards,
jamesob commented at 5:23 PM on November 26, 2019: member

Hi @brakmic. Those changes look good to me! You should just go ahead and open the PR. Thanks for contributing.
brakmic commented at 5:48 PM on November 26, 2019: contributor

Thanks! Ok, then I'll open a PR!
petterhs commented at 5:57 PM on November 26, 2019: none

Sorry @brakmic. My bad, didn't see that you had something proposed already. I'll close it
brakmic commented at 5:58 PM on November 26, 2019: contributor

No problem, @petterhs :) Thanks!
brakmic commented at 10:07 PM on November 27, 2019: contributor

Moved the original PR to https://github.com/bitcoin/bitcoin/pull/17623
bitcoin deleted a comment on Jan 4, 2020
MarcoFalke commented at 1:50 PM on May 31, 2020: member

@fanquake Any pointers on how this should be solved? I don't think this is a bug, but a feature.
MarcoFalke removed the label good first issue on Mar 25, 2022
MarcoFalke commented at 12:57 PM on March 25, 2022: member

Is this still an issue with a recent version of Bitcoin Core?
fanquake commented at 3:37 PM on August 6, 2022: member

Happy to close this.
fanquake closed this on Aug 6, 2022
bitcoin locked this on Aug 6, 2023

Contributors

Labels

Linked (view graph)

#17614 rpc: fix failure calling dumptxoutset with invalid filename #17615 rpc: check for irregular files in dumptxoutset #17623 rpc: add extensive file checks for dumptxoutset and dumpwallet