Fix. text reference to executable bitcoin-wallet instead of wallet-tool, there is not a wallet-tool at bin/ folder.
doc: rename wallet-tool references to bitcoin-wallet #17648
pull hel-o wants to merge 1 commits into bitcoin:master from hel-o:fix/typo changing 2 files +4 −4-
hel-o commented at 2:35 AM on December 2, 2019: contributor
- fanquake added the label Docs on Dec 2, 2019
- fanquake added the label Utils/log/libs on Dec 2, 2019
-
laanwj commented at 10:33 AM on December 2, 2019: member
there's two other mentions of the old name, maybe adopt those too
src/wallet/wallet.cpp: // If wallet doesn't have a chain (e.g wallet-tool), lock can't be taken. src/wallet/wallet.cpp: // tx status. If lock can't be taken (e.g wallet-tool), tx confirmation - fanquake added the label Waiting for author on Dec 2, 2019
-
hel-o commented at 2:33 PM on December 2, 2019: contributor
Commit done.
-
fanquake commented at 2:39 PM on December 2, 2019: member
Please squash your commits and update to use a commit message like
doc: rename wallet-tool references to bitcoin-wallet. -
DrahtBot commented at 4:33 PM on December 2, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #16426 (Reverse cs_main, cs_wallet lock order and reduce cs_main locking by ariard)
- #9381 (Remove CWalletTx merging logic from AddToWallet by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
doc: rename wallet-tool references to bitcoin-wallet e7ad4a2f8c
- hel-o force-pushed on Dec 2, 2019
- fanquake renamed this:
Fix. text reference to executable bitcoin-wallet
doc: rename wallet-tool references to bitcoin-wallet
on Dec 2, 2019 - fanquake removed the label Waiting for author on Dec 2, 2019
- fanquake approved
-
fanquake commented at 7:27 PM on December 2, 2019: member
ACK e7ad4a2f8c07a82d6424b473f0d51dbd8f897b10 - thanks for following up.
- laanwj referenced this in commit dcbe024f5e on Dec 4, 2019
- laanwj merged this on Dec 4, 2019
- laanwj closed this on Dec 4, 2019
- sidhujag referenced this in commit 17803e22a2 on Dec 4, 2019
- sidhujag referenced this in commit a3c6de588d on Dec 6, 2019
- jasonbcox referenced this in commit 37b9f1079b on Oct 1, 2020
- sidhujag referenced this in commit c18ac2b2e4 on Nov 10, 2020
- sidhujag referenced this in commit 3f159b5220 on Nov 10, 2020
- DrahtBot locked this on Dec 16, 2021
