depends: Support for S390X and POWER targets #17678

MarcoFalke commented at 5:34 PM on December 5, 2019: member

Failure before:

$ make -C depends HOST=powerpc64-linux-gnu
...
ERROR: Feature 'system-zlib' was enabled, but the pre-condition 'libs.zlib' failed.

ERROR: Feature 'xcb' was enabled, but the pre-condition 'libs.xcb' failed.

ERROR: Feature 'system-freetype' was enabled, but the pre-condition 'features.freetype && libs.freetype' failed.

ERROR: Feature 'fontconfig' was enabled, but the pre-condition '!config.win32 && !config.darwin && features.system-freetype && libs.fontconfig' failed.
make: *** [funcs.mk:254: /bitcoin/depends/work/build/powerpc64-linux-gnu/qt/5.9.8-95548079095/qtbase/.stamp_configured] Error 3


$ make -C depends HOST=s390x-linux-gnu
...
ERROR: Feature 'system-zlib' was enabled, but the pre-condition 'libs.zlib' failed.

ERROR: Feature 'xcb' was enabled, but the pre-condition 'libs.xcb' failed.

ERROR: Feature 'system-freetype' was enabled, but the pre-condition 'features.freetype && libs.freetype' failed.

ERROR: Feature 'fontconfig' was enabled, but the pre-condition '!config.win32 && !config.darwin && features.system-freetype && libs.fontconfig' failed.
make: *** [funcs.mk:254: /bitcoin/depends/work/build/s390x-linux-gnu/qt/5.9.8-79c6d6ca6ec/qtbase/.stamp_configured] Error 3

depends: Support for 64-bit POWER targets 989fd539d5

depends: Support for S390X targets 11113247c3

MarcoFalke added the label Build system on Dec 5, 2019

MarcoFalke added the label Needs gitian build on Dec 5, 2019

DrahtBot commented at 10:23 PM on December 5, 2019: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17661 (build: fix depends for s390x and use it in ci by elichai)
#12557 ([WIP] 64 bit iOS device support by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

elichai commented at 11:08 AM on December 8, 2019: contributor

Is this needed for cross compilation?

DrahtBot commented at 3:52 PM on December 8, 2019: member

Gitian builds

File	commit fc0da027e8cda1d7304e50315a848c353bae4822<br>(master)	commit 53431fcaf4d798bfb91bc6b0d2c8182818f3bd93<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`de8751e92d57e5b2...`	`e0df6903bff4ddeb...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`489fd32581f67e68...`	`54cea998fc4514af...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`c1a45efe722d7d3e...`	`1621677658bafc3e...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`3e53869094a514eb...`	`08654061cd17d8fa...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`302f566a1c2a27d1...`	`1aedf4233811e241...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`e7e36dbb8d8599ac...`	`19b93143d4142ae1...`
bitcoin-0.19.99-osx-unsigned.dmg	`783d6681fe4d8623...`	`9f1f13d5a0a7f559...`
bitcoin-0.19.99-osx64.tar.gz	`e3d1c893682d616a...`	`f9ee58e490f73366...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`e3474e1b5190b5d1...`	`ecd8d4b361399541...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`037c2bff8d25e513...`	`505e37cb0915c943...`
bitcoin-0.19.99-win64-debug.zip	`6107ee3f3f59680f...`	`be2b9f783a14a270...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`1693dfbccdcdce7a...`	`ba26049f83904022...`
bitcoin-0.19.99-win64.zip	`990d47c68a4fe32a...`	`d86ec91ebae297d3...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`d5e2d0ea06ba6c85...`	`d2c42bb0010facfb...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`25b69607857ed27c...`	`baed7ba4127e309e...`
bitcoin-0.19.99.tar.gz	`0488b26c0c1cf1d7...`	`d25181909e62919b...`
bitcoin-core-linux-0.20-res.yml	`efabe43ac9d48c89...`	`d890711f15a62ab9...`
bitcoin-core-osx-0.20-res.yml	`16ef33e79bb42f3a...`	`42b3175c97697587...`
bitcoin-core-win-0.20-res.yml	`434c1193f0d0a3d3...`	`a141c7bb14c9ef40...`
linux-build.log	`4e8b1b3e797e327f...`	`f5aad9abfc685737...`
osx-build.log	`e78108cf5eb78ff7...`	`b209dc8b8acf471b...`
win-build.log	`18ce8f02f41dc64d...`	`4ef6d2103075ab35...`
bitcoin-core-linux-0.20-res.yml.diff		`8e1fffa6377c00b5...`
bitcoin-core-osx-0.20-res.yml.diff		`734263e59028cec7...`
bitcoin-core-win-0.20-res.yml.diff		`8790bbbb9026aacc...`
linux-build.log.diff		`a196adedc6a11594...`
osx-build.log.diff		`4f9c21541e841747...`
win-build.log.diff		`34015725bb0d6f46...`

DrahtBot removed the label Needs gitian build on Dec 8, 2019

MarcoFalke commented at 4:28 PM on December 8, 2019: member

Is this needed for cross compilation?

Yes. I couldn't get cross compilation to work (see OP)

laanwj commented at 9:37 AM on December 9, 2019: member

Code review ACK 11113247c323c5b98debcb512fb9db9fe5a8e7cf Haven't tested cross-compile for these targets but this is definitely the kind of change that is needed for depends to support them.

dongcarl commented at 4:36 PM on December 9, 2019: member

tested ACK 11113247c323c5b98debcb512fb9db9fe5a8e7cf

Tested on Ubuntu Bionic docker containers after installing dependencies per https://github.com/bitcoin/bitcoin/blob/11113247c323c5b98debcb512fb9db9fe5a8e7cf/depends/README.md#for-linux-including-i386-arm-cross-compilation

practicalswift commented at 4:41 PM on December 9, 2019: contributor

ACK 11113247c323c5b98debcb512fb9db9fe5a8e7cf -- diff looks correct

MarcoFalke referenced this in commit 1d6fda65dd on Dec 9, 2019

MarcoFalke merged this on Dec 9, 2019

MarcoFalke closed this on Dec 9, 2019

MarcoFalke deleted the branch on Dec 9, 2019

sidhujag referenced this in commit 1d360bec67 on Dec 9, 2019

sidhujag referenced this in commit 839cbf7cca on Nov 10, 2020

MarcoFalke locked this on Dec 16, 2021