Currently the gitian-win-signer.yml produces OUTFILE names without -unsigned stripped out
This is due to regex having an% in front of it
$ INFILE="bitcoin-0.19.0-win64-setup-unsigned.exe"
$ echo "${INFILE/%-unsigned}"
bitcoin-0.19.0-win64-setup-unsigned.exe
$ echo "${INFILE/-unsigned}"
bitcoin-0.19.0-win64-setup.exe
Fixes #17361
the `-` is not a special symbol and should not have `%` in front of it.
Why is SC2001 disabled?
Why is SC2001 disabled?
It isn't, but it seems that it didn't pick up our mistake and assumed % was part of the pattern
@hebasto We need to fix the rest of them too... https://github.com/bitcoin/bitcoin/commit/17f81e96486780df5d464487975ecb11b278ec8d#diff-43ab305e977a53cc028bfb0eaaacf989
Why is SC2001 disabled?
It isn't, but it seems that it didn't pick up our mistake and assumed
%was part of the pattern@hebasto We need to fix the rest of them too... 17f81e9#diff-43ab305e977a53cc028bfb0eaaacf989
The rest are ok. . is a special character so it requires that % in front of it
Currently the gitian-win-signer.yml produces OUTFILE names without -unsigned stripped out
When was this problem introduced? On releases, this renaming definitely works and a filename without -unsigned is produced.
Currently the gitian-win-signer.yml produces OUTFILE names without -unsigned stripped out
When was this problem introduced? On releases, this renaming definitely works and a filename without
-unsignedis produced.
#17361 8 days ago. There's gitian builds in PR but did not include codesigned gitian builds
#17361 8 days ago. There's gitian builds in PR but did not include codesigned gitian builds
Sorry for introducing a bug. @willyko Thank you for fixing!
From bash docs:
${parameter/pattern/string}
The pattern is expanded to produce a pattern just as in filename expansion. Parameter is expanded and the longest match of pattern against its value is replaced with string. The match is performed according to the rules described below (see Pattern Matching). If pattern begins with ‘/’, all matches of pattern are replaced with string... If pattern begins with ‘%’, it must match at the end of the expanded value of parameter. If string is null, matches of pattern are deleted and the / following pattern may be omitted.
So this
$ INFILE="bitcoin-0.19.0-win64-setup-unsigned.exe"
$ echo "${INFILE/%-unsigned}"
bitcoin-0.19.0-win64-setup-unsigned.exe
does not work because -unsigned does not match at the end of "bitcoin-0.19.0-win64-setup-unsigned.exe".
The rest are ok.
.is a special character so it requires that%in front of it
I don't think . is a special character that requires % in front of it. The purpose of % is described in docs (see above).
ACK c966ff14c77870378847b9e6063b9671739ddc1f