script: Lint Gitian descriptors with ShellCheck #17361

   0 | @@ -0,0 +1,22 @@
   1 | +#!/usr/bin/env python3

---

 116 | +  CONFIG_SITE=${BASEPREFIX}/$(echo "${HOSTS}" | awk '{print $1;}')/share/config.site ./configure --prefix=/
 117 |    make dist
 118 | -  SOURCEDIST=`echo bitcoin-*.tar.gz`
 119 | -  DISTNAME=`echo ${SOURCEDIST} | sed 's/.tar.*//'`
 120 | +  SOURCEDIST=$(echo bitcoin-*.tar.gz)
 121 | +  DISTNAME=${SOURCEDIST//.tar.*/}

---

  35 | @@ -36,7 +36,7 @@ script: |
  36 |    ./configure --without-gsf --without-curl --disable-dependency-tracking
  37 |    make
  38 |    find ${UNSIGNED_DIR} -name "*-unsigned.exe" | while read i; do
  39 | -    INFILE="`basename "${i}"`"
  40 | -    OUTFILE="`echo "${INFILE}" | sed s/-unsigned//`"
  41 | +    INFILE="$(basename "${i}")"
  42 | +    OUTFILE="${INFILE//-unsigned/}"

---

 109 | +  CONFIG_SITE=${BASEPREFIX}/$(echo "${HOSTS}" | awk '{print $1;}')/share/config.site ./configure --prefix=/
 110 |    make dist
 111 | -  SOURCEDIST=`echo bitcoin-*.tar.gz`
 112 | -  DISTNAME=`echo ${SOURCEDIST} | sed 's/.tar.*//'`
 113 | +  SOURCEDIST=$(echo bitcoin-*.tar.gz)
 114 | +  DISTNAME=${SOURCEDIST//.tar.*/}

---

 146 | +  CONFIG_SITE=${BASEPREFIX}/$(echo "${HOSTS}" | awk '{print $1;}')/share/config.site ./configure --prefix=/
 147 |    make dist
 148 | -  SOURCEDIST=`echo bitcoin-*.tar.gz`
 149 | -  DISTNAME=`echo ${SOURCEDIST} | sed 's/.tar.*//'`
 150 | +  SOURCEDIST=$(echo bitcoin-*.tar.gz)
 151 | +  DISTNAME=${SOURCEDIST//.tar.*/}

---

  51 | +
  52 | +for descriptor in $(git ls-files -- 'contrib/gitian-descriptors/*.yml')
  53 | +do
  54 | +    echo
  55 | +    echo "$descriptor"
  56 | +    SCRIPT=$'#!/bin/bash\n'$(yq -r .script "$descriptor")

---

  95 | @@ -96,7 +96,7 @@ script: |
  96 |    export PATH=${WRAP_DIR}:${PATH}
  97 |  
  98 |    cd bitcoin
  99 | -  BASEPREFIX=`pwd`/depends
 100 | +  BASEPREFIX=$(pwd)/depends

---

 121 | @@ -122,7 +122,7 @@ script: |
 122 |    done
 123 |  
 124 |    cd bitcoin
 125 | -  BASEPREFIX=`pwd`/depends
 126 | +  BASEPREFIX=$(pwd)/depends

---