Don't display "Third party transaction URLs" setting when built with no wallet #17683

issue fanquake opened this issue on December 6, 2019

fanquake commented at 3:16 PM on December 6, 2019: member

The part of the GUI that this setting is relevant for does not exist in a --disable-wallet build.
fanquake added the label GUI on Dec 6, 2019
fanquake added the label good first issue on Dec 6, 2019
brakmic commented at 7:08 PM on December 6, 2019: contributor

Hi,

Here's my solution.

It's basically a series of C-style #ifdef / #endif's

Have also deactivated the context menu stuff. Yes, I know, there is no context menu at all, but just to be completely without any 3rd party Urls.

Regards,
brakmic commented at 7:01 PM on December 7, 2019: contributor

As the previous variant of my solution was failing on some architectures/configurations, I have now simplified it a lot. There's now only one #ifdef/endif left that disables the label/textbox for non-wallet builds.
fanquake closed this on Dec 9, 2019
MarcoFalke locked this on Dec 16, 2021
knst referenced this in commit e3c4af4311 on May 26, 2022
knst referenced this in commit aadf4908d9 on May 27, 2022
knst referenced this in commit 4c1477c7b3 on May 30, 2022

Contributors

Labels