cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice #17687

1. 
   brakmic commented at 9:36 AM on December 7, 2019: contributor

   This PR fixes #17679 by replacing BlockFilterType-vector with a set of the same type to make sure that only unique filter types get inserted.

2. cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice 034561f9cd
3. 
   MarcoFalke commented at 8:32 PM on December 11, 2019: member

   ACK 034561f9cd4180ea1c165cb02df6c84444a8d692 📖

   <details><summary>Show signature and timestamp</summary>

   Signature:

   -----BEGIN PGP SIGNED MESSAGE-----
   Hash: SHA512
   
   ACK 034561f9cd4180ea1c165cb02df6c84444a8d692 📖
   -----BEGIN PGP SIGNATURE-----
   
   iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
   pUiiCAwAkTUdRgM99rFNna7GHC1hXq43jyp2tF/fQ0woilnjFDTfg+OvtkFIOk6Y
   P8EdeRjzRO+dchOPHMkgLjNxi9SquFXUdtdeCcjUnXGgp3RuLX5KHOCHatpihMej
   NRehVVVbHybRpceCyBPj4hV+zrl+icyfCB56cBMaWIyLhRD+Hpp95jyPMMhXfWUC
   o2OyEXrARUvdvZhPM8YKZcJTK4AtHNMWu7MgSa6oeio5tvWN7xFJflvLQ2g6cSTb
   P6xYqVeDcrNYR2AjJSOtxFZlengHX0ny4Y1WIsyrxAAW3w7bzR2NCmhQK6pKJvDY
   PPc3Vu9PZggaPaBKj+zJhBxMY5aZ0aTNAEnbfnSqJNGAEbG1R81eZ6CJIIyyzI2F
   ihV2KIf7hOC3BL1VvCT07QuxVtd36PJFWDfJWRC+xD1yIrwIjbQNjlWhxjg/yGy/
   WuA0f9jcfi0mcGursI4MpihU18nsaNrhvIpM3K/1hnJKTTMSH3fhSR9m5LL7dNIG
   A2Eo/A3j
   =v3zO
   -----END PGP SIGNATURE-----
   

   Timestamp of file with hash 86ef0b41e0609b9aac3d83bc5ed495c7e7c9b8d1d452378fdf1636a6a5f4b0ea -

   </details>

4. 
   laanwj commented at 11:34 AM on December 12, 2019: member

   I think this could have been done with a smaller change: collect into a set at argument parsing, then copy it into the vector. A vector is slightly more efficient to iterate over than a set. But that doesn't matter here as the g_enabled_filter_types is only getting iterated over once :smile:

   ACK 034561f9cd4180ea1c165cb02df6c84444a8d692

5. fanquake approved
6. 
   fanquake commented at 1:04 PM on December 12, 2019: member

   ACK 034561f9cd4180ea1c165cb02df6c84444a8d692 - Tested with src/bitcoind --blockfilterindex=basic --blockfilterindex=basic

7. fanquake referenced this in commit cf2f439876 on Dec 12, 2019
8. fanquake merged this on Dec 12, 2019
9. fanquake closed this on Dec 12, 2019

   ---

10. brakmic deleted the branch on Dec 12, 2019
11. 
    laanwj commented at 3:41 PM on December 12, 2019: member

    Does this need backport to any branch?

12. laanwj added the label UTXO Db and Indexes on Dec 12, 2019
13. MarcoFalke added this to the milestone 0.19.1 on Dec 12, 2019
14. MarcoFalke added the label Needs backport (0.19) on Dec 12, 2019
15. 
    MarcoFalke commented at 3:59 PM on December 12, 2019: member

    0.19.1, if it is a clean cherry-pick

16. sidhujag referenced this in commit 4d79b3abce on Dec 12, 2019
17. fanquake referenced this in commit bda2f5b3c9 on Jan 3, 2020
18. fanquake removed the label Needs backport (0.19) on Jan 5, 2020
19. 
    fanquake commented at 12:00 AM on January 6, 2020: member

    Being backported in 17858.

20. laanwj referenced this in commit bb123c6527 on Jan 8, 2020
21. MarkLTZ referenced this in commit 2e6abb1507 on Mar 13, 2020
22. MarkLTZ referenced this in commit ece88bae51 on Mar 13, 2020
23. jasonbcox referenced this in commit de41d25ec5 on Nov 9, 2020
24. sidhujag referenced this in commit e4fb224df4 on Nov 10, 2020
25. kittywhiskers referenced this in commit 045fbcd347 on Aug 22, 2021
26. kittywhiskers referenced this in commit 53d543b265 on Aug 22, 2021
27. kittywhiskers referenced this in commit 71122826a5 on Sep 16, 2021
28. kittywhiskers referenced this in commit b2ae73cff4 on Sep 18, 2021
29. UdjinM6 referenced this in commit 4ffd42de63 on Sep 21, 2021
30. thelazier referenced this in commit ba244e8a44 on Sep 25, 2021
31. kittywhiskers referenced this in commit 06e5c284c5 on Oct 12, 2021
32. Munkybooty referenced this in commit 861ef02929 on Dec 9, 2021
33. Munkybooty referenced this in commit fc6f77f098 on Dec 9, 2021
34. Munkybooty referenced this in commit e32f0d5d86 on Dec 9, 2021
35. Munkybooty referenced this in commit 16f7583e71 on Dec 23, 2021
36. DrahtBot locked this on Feb 15, 2022

Milestone
0.19.1