There was an issue around the time of Qt 4.6 when placeholder text was introduced, that caused a compile failure when it was specified in the form.
As a workaround the placeholder texts were moved to the code.
Qt 4 hasn't been relevant to us for ages. So move all (non-parametrized) placeholder texts to the form files instead.
It's better to keep this kind of text content together. Translate/no-translate status is kept as it is.
Proof that they still work:
There was an issue around the time of Qt 4.6 when placeholder text was
introduced, that caused a compile failure when it was specified in the
form.
As a workaround the placeholder texts were moved to the code.
Qt 4 hasn't been relevant to us for ages. So move all (non-parametrized)
placeholder texts to the form files instead.
It's better to keep this kind of text content together. Makes sure
translate/no-translate status is kept as it is.
143 | @@ -144,6 +144,9 @@ 144 | <property name="toolTip"> 145 | <string>Enter a label for this address to add it to the list of used addresses</string> 146 | </property> 147 | + <property name="placeholderText"> 148 | + <string>Enter a label for this address to add it to your address book</string>
It's kind of strange to have the same thing worded in two different ways here. We might want to change this message to "Enter a label for this address to add it to the list of used addresses" as well (I think that's preferred to "address book"?). If people agree I'll do this in a new commit.
If people agree I'll do this in a new commit.
Yes, please.
thx, done
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Concept ACK.
ACK 67f36e0b2ce0f99b90578e7e1dd9e0624026bcfa, I have reviewed the code and it looks OK, I agree it can be merged.
Verified that other objects which use QLineEdit::setPlaceholderText() method have no corresponding *.ui forms.
Re-ACK a652dc5521e2caf5734ffb797c7f2fc80685fef1, tooltip and placeholderText are identical now.
ACK a652dc5521e2caf5734ffb797c7f2fc80685fef1 - checked that placeholder text still appears.
Typed make translated and verified that the translations still work and exist.
ACK a652dc5521e2caf5734ffb797c7f2fc80685fef1 🚿
<details><summary>Show signature and timestamp</summary>
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK a652dc5521e2caf5734ffb797c7f2fc80685fef1 🚿
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgRiwwAw9cEXQKjQhNBOoI6jWuiup9tN+ZlstBfwFGUAHo2XFBoswA31k1poJOV
5AWVMk4dWRjlXqpwNGSUwl8elHGnvbEyaKJOHR5b5i2/Jed3LvmOvs+sWyxVVnYl
SAS+dD4iZG6CiWKA1WD6QEIFhBgVwTjIIlwrF1QDyu/EWrqI0T7JsbYW42VfBTfv
laPyGDkSw2DG7xLMHAfYNs1d+uY6x5oEd81XIdgvwxXenQKErBYfBmir6IpPjXIa
1ABSuHwqouEGN3MpuNYZX8zjbilKCkA3Ej7pBpcpcuCHQcXRBuQxKDkjpiuR9UPd
IVv38ZiPRKGLlpj2CxrhZJACgjf6I2fyPZ5ea0yzLI0iyp51hQigQ3m5SBrkVx2m
NiQ4uEmskPD8pej3IKyj1INwEX5shFAVDRw1TcToR6w32DjOWGJfi5JQ+ieTNLuI
SsmUGRZfCsREcSaTdtwvRM9BnoNyKsDQyK+tP0EfmyWevy2F39C76CwSvDQIEvMT
ziCMwOUJ
=3B7n
-----END PGP SIGNATURE-----
Timestamp of file with hash 1861b0f77d9a81d6407df8c3c7977e8b6bac8fa9dd0213dd982576c78ef08c68 -
</details>
