build: set AC_PREREQ to 2.69 #17769

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:set_ac_prereq_264 changing 1 files +1 −2
  1. fanquake commented at 3:41 AM on December 18, 2019: member

    We use build macros such as AX_CHECK_LINK_FLAG, that require >=2.64, so our configure should also require Autoconf >= 2.64. The build would already blow up if 2.64 wasn't available. i.e:

    configure.ac:320: error: Autoconf version 2.64 or higher is required
    build-aux/m4/ax_check_link_flag.m4:74: AX_CHECK_LINK_FLAG is expanded from...
    

    For reference, Autoconf 2.69 was released in April of 2012.

    See the Autoconf Versioning docs for more info on AC_PREREQ.

  2. fanquake added the label Build system on Dec 18, 2019
  3. hebasto approved
  4. hebasto commented at 5:39 AM on December 18, 2019: member

    ACK b16df46a88bc09623899320f121ed89f65fdf376, I have reviewed the code and it looks OK, I agree it can be merged.

    One of the most conservative distro CentOS 7 has autoconf 2.69. Interesting, which supported distros use autoconf 2.64?

  5. laanwj commented at 10:51 AM on December 18, 2019: member

    ACK b16df46a88bc09623899320f121ed89f65fdf376 ACK 4f4ae6f97e210fa0a2aa274bcd2a77a226fe6a7e Concept ACK, I'm also ok with bumping it to 2.69

  6. build: set AC_PREREQ to 2.69
    We use build macros such as AX_CHECK_LINK_FLAG, that require >=2.64, so
    our configure should also require Autoconf >= 2.64. The build would
    already blow up if 2.64 wasn't available. i.e:
    
    configure.ac:320: error: Autoconf version 2.64 or higher is required
    build-aux/m4/ax_check_link_flag.m4:74: AX_CHECK_LINK_FLAG is expanded from...
    
    For reference, Autoconf 2.69 was released in April of 2012.
    https://lists.gnu.org/archive/html/autoconf/2012-04/msg00041.html
    
    See https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Versioning.html
    for more info on AC_PREREQ.
    4f4ae6f97e
  7. fanquake force-pushed on Dec 18, 2019
  8. fanquake renamed this:
    build: set AC_PREREQ to 2.64
    build: set AC_PREREQ to 2.69
    on Dec 18, 2019
  9. fanquake commented at 9:39 PM on December 18, 2019: member

    Concept ACK, I'm also ok with bumping it to 2.69

    Updated to 2.69. Availability of 2.69 is extensive across all the operating systems we support.

  10. hebasto commented at 6:43 AM on December 19, 2019: member

    re-ACK 4f4ae6f97e210fa0a2aa274bcd2a77a226fe6a7e, Autoconf 2.69 seems wide available.

  11. fanquake referenced this in commit 7f9fbb89e8 on Dec 19, 2019
  12. fanquake merged this on Dec 19, 2019
  13. fanquake closed this on Dec 19, 2019

  14. fanquake deleted the branch on Dec 19, 2019
  15. laanwj referenced this in commit 3b21a78634 on Mar 11, 2020
  16. sidhujag referenced this in commit 3d70d6cd40 on Mar 11, 2020
  17. sidhujag referenced this in commit 523d83911e on Nov 10, 2020
  18. PastaPastaPasta referenced this in commit 03bb66d9f3 on Jun 27, 2021
  19. PastaPastaPasta referenced this in commit 5aa2fea401 on Jun 27, 2021
  20. PastaPastaPasta referenced this in commit fcc9afcec0 on Jun 28, 2021
  21. PastaPastaPasta referenced this in commit cbaae225d8 on Jun 28, 2021
  22. PastaPastaPasta referenced this in commit 36728460d1 on Jun 29, 2021
  23. PastaPastaPasta referenced this in commit a0b16543ef on Jun 29, 2021
  24. PastaPastaPasta referenced this in commit 4ad967f8ca on Jul 1, 2021
  25. PastaPastaPasta referenced this in commit f2836e5b64 on Jul 1, 2021
  26. PastaPastaPasta referenced this in commit 4a0ca96243 on Jul 1, 2021
  27. PastaPastaPasta referenced this in commit c29a932c9f on Jul 1, 2021
  28. PastaPastaPasta referenced this in commit 48f23d4850 on Jul 14, 2021
  29. PastaPastaPasta referenced this in commit 2f4413304f on Jul 14, 2021
  30. PastaPastaPasta referenced this in commit 112709c153 on Jul 14, 2021
  31. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me