fanquake
commented at 3:41 AM on December 18, 2019:
member
We use build macros such as AX_CHECK_LINK_FLAG, that require >=2.64, so our configure should also require Autoconf >= 2.64. The build would already blow up if 2.64 wasn't available. i.e:
configure.ac:320: error: Autoconf version 2.64 or higher is required
build-aux/m4/ax_check_link_flag.m4:74: AX_CHECK_LINK_FLAG is expanded from...
For reference, Autoconf 2.69 was released in April of 2012.
fanquake added the label Build system on Dec 18, 2019
hebasto approved
hebasto
commented at 5:39 AM on December 18, 2019:
member
ACKb16df46a88bc09623899320f121ed89f65fdf376, I have reviewed the code and it looks OK, I agree it can be merged.
One of the most conservative distro CentOS 7 has autoconf 2.69. Interesting, which supported distros use autoconf 2.64?
laanwj
commented at 10:51 AM on December 18, 2019:
member
ACKb16df46a88bc09623899320f121ed89f65fdf376ACK4f4ae6f97e210fa0a2aa274bcd2a77a226fe6a7eConcept ACK, I'm also ok with bumping it to 2.69
build: set AC_PREREQ to 2.69
We use build macros such as AX_CHECK_LINK_FLAG, that require >=2.64, so
our configure should also require Autoconf >= 2.64. The build would
already blow up if 2.64 wasn't available. i.e:
configure.ac:320: error: Autoconf version 2.64 or higher is required
build-aux/m4/ax_check_link_flag.m4:74: AX_CHECK_LINK_FLAG is expanded from...
For reference, Autoconf 2.69 was released in April of 2012.
https://lists.gnu.org/archive/html/autoconf/2012-04/msg00041.html
See https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Versioning.html
for more info on AC_PREREQ.
4f4ae6f97e
fanquake force-pushed on Dec 18, 2019
fanquake renamed this: build: set AC_PREREQ to 2.64 build: set AC_PREREQ to 2.69 on Dec 18, 2019
fanquake
commented at 9:39 PM on December 18, 2019:
member
Concept ACK, I'm also ok with bumping it to 2.69
Updated to 2.69. Availability of 2.69 is extensive across all the operating systems we support.
hebasto
commented at 6:43 AM on December 19, 2019:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-24 21:14 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me