gui: Shortcut to close RPC Console #17795

pull emilengler wants to merge 1 commits into bitcoin:master from emilengler:2019-12-gui-close-rpcconsole-shortcut changing 2 files +11 −0

emilengler commented at 9:54 PM on December 23, 2019: contributor

Credits to promag. Similar to #16515 with a macOS addition.

This PR makes it possible to close the RPC Console (like a terminal) with Ctrl+D. On macOS it will close with Ctrl+W as it is a more common syntax there.

gui: Shortcut to close RPC Console

Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>

f0e1895cb3

fanquake added the label GUI on Dec 23, 2019
DrahtBot commented at 1:27 AM on December 24, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17636 (qt: Add -guisettingsdir option by emilengler)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
luke-jr commented at 7:28 PM on January 3, 2020: member

Doesn't Ctrl-D work in macOS Terminal too?

I think it makes more sense to just do Ctrl-D here, and let the other PR add Ctrl-W too.
emilengler commented at 8:25 PM on January 3, 2020: contributor

Doesn't Ctrl-D work in macOS Terminal too?

Well yes but actually no It terminates the shell process but the window remains open asying that the process was terminated successfully
fanquake commented at 12:07 AM on March 5, 2020: member

Going to close with the same rationale as #16515. This hasn't seen any renewed interest and I think the project has more important things to work on. Ideally all of this kind of thing would be handled by Qt.
fanquake closed this on Mar 5, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels