build: depends macOS: hide linker visibility warnings #17839

pull rex4539 wants to merge 1 commits into bitcoin:master from rex4539:hide-warnings changing 1 files +2 −2
  1. rex4539 commented at 10:47 AM on December 31, 2019: contributor

    Removes 3167 linker warnings when compiling for macOS.

    Warnings like this one:

    ld: warning: direct access in function 'boost::filesystem::detail::create_directories(boost::filesystem::path const&, boost::system::error_code*)' from file '/Users/rex/bitcoin/depends/x86_64-apple-darwin19.0.0/lib/libboost_filesystem-mt-x64.a(operations.o)' to global weak symbol 'boost::system::generic_category()::generic_category_instance' from file 'libbitcoin_util.a(libbitcoin_util_a-time.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
    
  2. [build] depends macOS: hide linker visibility warnings b8b6fb4aaa
  3. fanquake added the label Build system on Dec 31, 2019
  4. fanquake renamed this:
    [build] depends macOS: hide linker visibility warnings
    build: depends macOS: hide linker visibility warnings
    on Dec 31, 2019
  5. MarcoFalke added the label Needs gitian build on Dec 31, 2019
  6. fanquake commented at 5:42 PM on December 31, 2019: member

    @rex4539 Please fill out the PR body and/or add more information to the commit itself. What warnings is this fixing, why is adding the -fvisibility options the correct fix etc.

  7. DrahtBot commented at 3:19 AM on January 2, 2020: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds

    File commit 35fff5be60e853455abc24713481544e91adfedb<br>(master) commit a7185e799e9da4dd6af84c4980110d98d4dce8b4<br>(master and this pull)
    bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz 1a1b79c30ee23b1e... 8bb9699200819232...
    bitcoin-0.19.99-aarch64-linux-gnu.tar.gz 4f5477e988e15339... 2b54cbfc3c3372f4...
    bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz 907d28fc95980468... 348a41bf86e1e8ca...
    bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz e55899ead1a7ff56... 3ada5c34354a966d...
    bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz 95fa4bccc8b22ac0... c476a12a98b7e1a8...
    bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz 340c796226da90c7... 04094475c95b0ae1...
    bitcoin-0.19.99-osx-unsigned.dmg 1c5ab941efd90df4... a442cccb319d0ebc...
    bitcoin-0.19.99-osx64.tar.gz e0d2d4ef7befbf1f... 02ca3ddb0a94f9e6...
    bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz 7fb3888850d15c57... 7f844119aa8a2428...
    bitcoin-0.19.99-riscv64-linux-gnu.tar.gz c6bd3037c22bbde5... 7fe396b134808226...
    bitcoin-0.19.99-win64-debug.zip a2369f394ffcb551... de447a58d2f32698...
    bitcoin-0.19.99-win64-setup-unsigned.exe ffc23fa5abc3ca5f... b84caecc73cc30fa...
    bitcoin-0.19.99-win64.zip 2d13e80f0011ce7d... debf0cbc83a086f8...
    bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz 2a4aa0a81c4d2591... ac8d6d171abcbf2e...
    bitcoin-0.19.99-x86_64-linux-gnu.tar.gz 8940a74e71b82107... bb5147c344c9b81c...
    bitcoin-0.19.99.tar.gz 7703c9c861b5b755... 4e33d079d2497fbc...
    bitcoin-core-linux-0.20-res.yml 5db46f5eca4bb180... 0147d9f26c25dc65...
    bitcoin-core-osx-0.20-res.yml 9db10d1794650fb3... cb73fd5a3806c46c...
    bitcoin-core-win-0.20-res.yml 89078fed82c8928e... bf7ea9fbc04b12f8...
    linux-build.log a3067a2425690fd1... 30bccd4150878860...
    osx-build.log a15a76ffd1535083... 2c464da08733437c...
    win-build.log b886d0e4dc768265... 1c54059118b6bed9...
    bitcoin-core-linux-0.20-res.yml.diff e3969605acb128ae...
    bitcoin-core-osx-0.20-res.yml.diff df202598d93d95ec...
    bitcoin-core-win-0.20-res.yml.diff 750c0b75eefcb44f...
    linux-build.log.diff 2a568cf62269182c...
    osx-build.log.diff bbe8cfeae679b1d7...
    win-build.log.diff 2ae9b0b009e6f349...
  8. DrahtBot removed the label Needs gitian build on Jan 2, 2020
  9. Sjors commented at 5:04 AM on January 5, 2020: member

    I'd love to get rid of these warnings, but agree with @fanquake that this needs more explanation. Simply suppressing warnings can be risky.

  10. rex4539 commented at 6:26 PM on March 4, 2020: contributor

    Withdrawing due to no interest.

  11. rex4539 closed this on Mar 4, 2020

  12. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me