Currently, we don't check if curl is actually installed on the user computer when suggesting it in the RPC help.
This PR checks for cURL in the PATH environment variable (it is defined by Posix). If a file called "curl" is found in the path, we return the current code command. Otherwise we just return an empty string. If the envvar can't be obtained for some reasons, we display the command anyways.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Concept NACK. bitcoind shouldn't be probing users systems to check what programs they may have installed. The examples are just that, examples.
But how is an example useful if it isn't usable on the machine?
But how is an example useful if it isn't usable on the machine?
The user could install it. if you have a more "universal" example than let's just replace the current one with the more universal one. but if the check is just to remove an example then I don't think it's useful, I'd rather show the user an example which A. might give him a notion of how the request should look like. B. he might just install curl if he wants to copy-paste the example.
Ok, will close then