scripts: fix symbol-check & security-check argument passing #17857

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:security_check_args changing 1 files +2 −2
  1. fanquake commented at 11:29 am on January 3, 2020: member

    The first argument in bin_PROGRAMS (bitcoind) was being silently consumed and never passed into the security-check.py or symbol-check.py scripts.

    This seems to have been the case since the scripts were added to the makefile in https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719.

    Example of the behavior:

     0# touch a, touch b, touch c
     1# python3 args.py < a b c
     2
     3import sys
     4if __name__ == '__main__':
     5    print(sys.argv)
     6    # ['args.py', 'b', 'c']
     7
     8    # if you add some lines to "a",
     9    # you'll see them here..
    10    for line in sys.stdin:
    11        print(line)
    
  2. scripts: fix check-symbols & check-security argument passing
    The first argument in bin_PROGRAMS (bitcoind) was being silently
    dropped and never passed into the check-security.py or check-symbols.py scripts.
    
    This has been the case since the scripts were added to the makefile in
    https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719.
    
    Example of the behavior:
    
    ```python
    # touch a, touch b, touch c
    # python3 args.py < a b c
    
    import sys
    if __name__ == '__main__':
        print(sys.argv)
        # ['args.py', 'b', 'c']
    
        # if you add some lines to "a",
        # you'll see them here..
        for line in sys.stdin:
            print(line)
    ```
    71af793512
  3. fanquake added the label Scripts and tools on Jan 3, 2020
  4. fanquake added the label Needs backport (0.19) on Jan 3, 2020
  5. fanquake added the label Needs gitian build on Jan 3, 2020
  6. fanquake added the label Needs backport (0.18) on Jan 3, 2020
  7. luke-jr approved
  8. luke-jr commented at 8:02 pm on January 3, 2020: member
    utACK
  9. laanwj commented at 1:18 pm on January 4, 2020: member

    ACK 71af793512100ee7d508c3fb815af47925fe80ba

    Very good catch, this has been in there forever and no one noticed.

  10. DrahtBot commented at 1:57 pm on January 4, 2020: member

    Gitian builds

    File commit 816464198c34a373229e865d76f4bc0ca8f127dc(master) commit 3984704eb1c3a337fa3fd67cdcc53d377c1b0a3d(master and this pull)
    bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz 44922e8e8056848d... c758b7ad25af9e6d...
    bitcoin-0.19.99-aarch64-linux-gnu.tar.gz 05e1ce01f4bf027d... 5481df69ed47ce0d...
    bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz 8e37da4406eb7acb... 137cd91618fa25ac...
    bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz a078a795e186bcbd... 047274edcdd0693e...
    bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz 9bfc0a6fe7481f5e... 65959bd7a983cc3c...
    bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz c917b138b0c941a5... e0978951c3541aba...
    bitcoin-0.19.99-osx-unsigned.dmg 589b596a1b693eca... b48a407d0bc42a91...
    bitcoin-0.19.99-osx64.tar.gz b39739108f501572... e6ae136ef7b2fbc5...
    bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz e5487c9851e1678c... d1518ae7cccceab3...
    bitcoin-0.19.99-riscv64-linux-gnu.tar.gz 5e0dd58e2489a3ab... 31b045fd16699141...
    bitcoin-0.19.99-win64-debug.zip 78ab3af68974e6e1... 639024956e6b0b56...
    bitcoin-0.19.99-win64-setup-unsigned.exe d2fce10be17e1d35... dd51f351f6da30ee...
    bitcoin-0.19.99-win64.zip 1a39280efc5077b5... 87cdda99f786f4f7...
    bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz 6739a94f4b04568e... c40ecc8a933066e8...
    bitcoin-0.19.99-x86_64-linux-gnu.tar.gz e5e94beee2ea4f46... 92e9801981163243...
    bitcoin-0.19.99.tar.gz 93bec1907b4d58b3... 6d132fcecba379d4...
    bitcoin-core-linux-0.20-res.yml dffd71e9e247fad1... 302f5e29817f1ebf...
    bitcoin-core-osx-0.20-res.yml ebc37399cc1ef1f8... ac070d55f3ed1e05...
    bitcoin-core-win-0.20-res.yml cdd1865daaf6dd5f... 9df6fef06f6edf99...
    linux-build.log ae16b8ec277565ff... 6b9a71ce72a1879f...
    osx-build.log 0521c51bbcd325db... ad518d15f5c1d5c0...
    win-build.log 5495d74485ba0616... d809c129326c1626...
    bitcoin-core-linux-0.20-res.yml.diff 1ae8a49d2466fbae...
    bitcoin-core-osx-0.20-res.yml.diff 0c2351746bc1321c...
    bitcoin-core-win-0.20-res.yml.diff 0b4a9039e825e03c...
    linux-build.log.diff 405d95eaed7ee937...
    osx-build.log.diff e9343641fe18b4a5...
    win-build.log.diff 9796ac18e0c613ef...
  11. DrahtBot removed the label Needs gitian build on Jan 4, 2020
  12. dongcarl commented at 5:18 am on January 6, 2020: member
    :fearful: Great catch! utACK.
  13. fanquake referenced this in commit e8e79958a7 on Jan 6, 2020
  14. fanquake merged this on Jan 6, 2020
  15. fanquake closed this on Jan 6, 2020

  16. fanquake referenced this in commit 99b54076ff on Jan 6, 2020
  17. fanquake deleted the branch on Jan 6, 2020
  18. fanquake removed the label Needs backport (0.19) on Jan 6, 2020
  19. fanquake commented at 7:52 am on January 6, 2020: member
    Added to 17858 for backport in 0.19.
  20. fanquake referenced this in commit 9a0ebb7f02 on Jan 6, 2020
  21. fanquake removed the label Needs backport (0.18) on Jan 6, 2020
  22. fanquake commented at 7:58 am on January 6, 2020: member
    Backported to the 0.18 branch in #17881.
  23. sidhujag referenced this in commit 7ec2fe7a0c on Jan 6, 2020
  24. laanwj referenced this in commit bb123c6527 on Jan 8, 2020
  25. fanquake referenced this in commit a05d14d4a0 on Jan 12, 2020
  26. laanwj referenced this in commit a3d198c93c on Jan 22, 2020
  27. sidhujag referenced this in commit 67671cbe66 on Jan 24, 2020
  28. MarkLTZ referenced this in commit 2e6abb1507 on Mar 13, 2020
  29. MarkLTZ referenced this in commit ece88bae51 on Mar 13, 2020
  30. azuchi referenced this in commit d8ef6cd4ab on Aug 11, 2020
  31. sidhujag referenced this in commit f69fe4e96d on Nov 10, 2020
  32. sidhujag referenced this in commit 4393ded651 on Nov 10, 2020
  33. Munkybooty referenced this in commit 861ef02929 on Dec 9, 2021
  34. Munkybooty referenced this in commit fc6f77f098 on Dec 9, 2021
  35. Munkybooty referenced this in commit e32f0d5d86 on Dec 9, 2021
  36. Munkybooty referenced this in commit 16f7583e71 on Dec 23, 2021
  37. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 19:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me