[0.19] Backports #17858

1. 
   fanquake commented at 12:01 PM on January 3, 2020: member

   Backports the following PRs to the 0.19 branch:

   • #17654 - Unbreak build with Boost 1.72.0
   • #17695 - gui: disable File->CreateWallet during startup
   • #17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice
   • #17728 - rpc: require second argument only for scantxoutset start action
   • #17450 - util: Add missing headers to util/fees.cpp
   • #17488 - test: fix "bitcoind already running" warnings on macOS
   • #17762 - Log to net category for exceptions in ProcessMessages
   • #17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes
   • #17416 - Appveyor improvement - text file for vcpkg package list
   • #17736 - Update msvc build for Visual Studio 2019 v16.4
   • #17857 - scripts: fix symbol-check & security-check argument passing

   Fixes #17856.

2. wallet: unbreak with boost 1.72

   wallet/walletutil.cpp:77:23: error: no member named 'level' in 'boost::filesystem::recursive_directory_iterator'
           } else if (it.level() == 0 && it->symlink_status().type() == fs::regular_file && IsBerkeleyBtree(it...
                      ~~ ^
   
   Github-Pull: #17654
   Rebased-From: a64e97dd476bda7c7981979d045b0d06d6f7ce47

   b9f1bc0fc1
3. gui: disable File->CreateWallet during startup

   Github-Pull: #17695
   Rebased-From: d65fafc2f7d98ab2be0a0961e7a3ebe7850c1dca

   d14ab7c522
4. cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice

   Github-Pull: #17687
   Rebased-From: 034561f9cd4180ea1c165cb02df6c84444a8d692

   bda2f5b3c9
5. rpc: require second argument only for scantxoutset start action

   The second argument of scanobjects is only required for the start action.
   Stop and abort actions do not need this.
   
   Github-Pull: #17728
   Rebased-From: 7d263571bee8c36fbe3c854b69c6f31cf1ee3b9b

   4d7875c555
6. fanquake added the label Backport on Jan 3, 2020
7. fanquake added this to the milestone 0.19.1 on Jan 3, 2020
8. 
   hebasto commented at 12:04 PM on January 3, 2020: member

   #17450 (comment) ?

9. util: Add missing headers to util/fees.cpp

   Github-Pull: #17450
   Rebased-From: b1315241375211563e9ec00391c4ac5310e1146f

   5276b0e5a2
10. fanquake requested review from luke-jr on Jan 4, 2020
11. test: fix bitcoind already running warnings on macOS

    On macOS, pidof installed via brew returns b'' rather than None.
    Account for this, to remove spurious warnings from the test_runner.
    
    Github-Pull: #17488
    Rebased-From: 1c23ea5fe67b88fd72a1ff640dd1bbb21a34fbf4

    c0dc728206
12. net: Log to net category for exceptions in ProcessMessages

    Remove the forest of special exceptions, and simply log a short
    message to the NET logging category when an exception happens during
    packet processing. It is not good to panick end users with errors
    that any peer can generate (let alone writing to stderr).
    
    Github-Pull: #17762
    Rebased-From: 4d88c3dcb61e7c075ed3dd442044e0eff4e3c8de

    1a6a534665
13. Add missing typeinfo includes

    The use of `typeid()` for logging exception types requires this include
    according to https://en.cppreference.com/w/cpp/language/typeid.
    
    Github-Pull: #17762
    Rebased-From: 4bdd68f301a9cee3360deafc7531c638e923226b

    112144dc52
14. Updated appveyor config:

     - Update build image from Visual Studio 2017 to Visual Studio 2019.
     - Updated Qt static library from Qt5.9.7 to Qt5.9.8.
     - Added commands to update vcpkg port files (this does not update already installed packages).
     - Updated vcpkg package list as per #17309.
     - Removed commands setting common project file options. Now done via common.init.vcxproj include.
     - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration.
    Updated msvc project configs:
     - Updated platform toolset from v141 to v142.
     - Updated Qt static library from Qt5.9.7 to Qt5.9.8.
     - Added ignore for linker warning building bitcoin-qt program.
     - Added missing util/str.cpp class file to test_bitcoin project file.
    
    Github-Pull: #17364
    Rebased-From: 3c84deebaa311155ccc7565d09525041eed9747c

    cd7b3b254a
15. Moves vcpkg list to a text file and updates the appveyor job and readme to use it.

    Github-Pull: #17416
    Rebased-From: 29eb039252f35a3bb58b0027f172cfe3d0c79867

    b0f9b8e648
16. Update msvc build for Visual Studio 2019 v16.4

    msvc warning C4834 for the Bitcoin Core build was introduced by Visual Studio 16.4.0. This PR adds an ignore rule for the warning (it's related to the nodiscard attribute and is not considered relevant).
    An additional side effect of the msvc compiler update is the prebuilt Qt5.9.8 libraries cannot be linked due to being built with an earlier version of the compiler. To fix this a new Qt5.9.8 version has been compiled and the appveyor job updated to use them. The GitHub Actions job needs to continue to use the original Qt5.9.8 libraries until the latest GitHub Windows image also updates to >= Visual Studio 2019 v16.4.
    
    Github-Pull: #17736
    Rebased-From: 75d9317bc1aecaab95bf875f8dca97ac3daddff4

    4330a1ee7f
17. scripts: fix check-symbols & check-security argument passing

    The first argument in bin_PROGRAMS (bitcoind) was being silently
    dropped and never passed into the check-security.py or check-symbols.py scripts.
    
    This has been the case since the scripts were added to the makefile in
    https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719.
    
    Example of the behavior:
    
    ```python
    
    import sys
    if __name__ == '__main__':
        print(sys.argv)
        # ['args.py', 'b', 'c']
    
        # if you add some lines to "a",
        # you'll see them here..
        for line in sys.stdin:
            print(line)
    ```
    
    Github-Pull: #17857
    Rebased-From: 71af793512100ee7d508c3fb815af47925fe80ba

    99b54076ff
18. 
    sipsorcery commented at 12:38 PM on January 6, 2020: member

    ACK (tested: Windows 10 & msvc build) 99b54076ff2d2dd357dafb9f0275713cd8d0111f.

19. 
    laanwj commented at 2:12 PM on January 8, 2020: member

    ACK 99b54076ff2d2dd357dafb9f0275713cd8d0111f

20. laanwj referenced this in commit bb123c6527 on Jan 8, 2020
21. laanwj merged this on Jan 8, 2020
22. laanwj closed this on Jan 8, 2020

    ---

23. fanquake deleted the branch on Jan 8, 2020
24. MarkLTZ referenced this in commit 2e6abb1507 on Mar 13, 2020
25. MarkLTZ referenced this in commit ece88bae51 on Mar 13, 2020
26. Munkybooty referenced this in commit 861ef02929 on Dec 9, 2021
27. Munkybooty referenced this in commit fc6f77f098 on Dec 9, 2021
28. Munkybooty referenced this in commit e32f0d5d86 on Dec 9, 2021
29. Munkybooty referenced this in commit 16f7583e71 on Dec 23, 2021
30. DrahtBot locked this on Feb 15, 2022

Review Requested
luke-jr

Milestone
0.19.1