It requires some time to compile on slow machines, so to avoid changing global gpg settings and avoid timeouts - system bell? Sorry if it's not the most elegant approach.
scripts: Add system notice prior signing functions in gitian-build.py #17865
pull charlesrocket wants to merge 1 commits into bitcoin:master from charlesrocket:system_notice-gitian changing 1 files +5 −0-
charlesrocket commented at 5:57 AM on January 4, 2020: none
-
Add system notice prior signing 8e9af76206
- charlesrocket renamed this:
scripts: Add system notice for prior signing functions in gitan-build.py
scripts: Add system notice for prior signing functions in gitian-build.py
on Jan 4, 2020 - fanquake added the label Scripts and tools on Jan 4, 2020
- charlesrocket renamed this:
scripts: Add system notice for prior signing functions in gitian-build.py
scripts: Add system notice prior signing functions in gitian-build.py
on Jan 4, 2020 -
fanquake commented at 6:39 AM on January 4, 2020: member
Concept NACK. What is this fixing exactly, and why does adding a bunch of prints fix it?
so to avoid changing global gpg settings and avoid timeouts
It's highly unlikely we are going to merge this into our gitian descriptors instead of you adjusting your settings.
-
charlesrocket commented at 6:53 AM on January 4, 2020: none
@fanquake This is no bug fix, just an addon for gitian builders. This is to avoid timeouts in case you out of the machine :) I was looking for another way but thats all I got to keep it multiplatform. On the other hand - you don't want to change the timeout, for security reasons. Again, Im not a fan of extra lines as well, but thats all I could get to keep it across all platforms. Just retrograding.
-
fanquake commented at 8:11 AM on January 4, 2020: member
Right. In that case, thanks for the PR, but this seems like something you should be solving locally.
- fanquake closed this on Jan 4, 2020
- charlesrocket deleted the branch on Jan 5, 2020
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels