In bitcoinunits.h some #defines introduced in #4167 are unused now.
refactor: Remove unused defines in qt/bitcoinunits.h #17869
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20200104-refactor-bitcoinunits changing 1 files +0 −19-
hebasto commented at 12:25 PM on January 4, 2020: member
-
refactor: Remove unused defines in bitcoinunits.h 7754d7ab1e
- fanquake added the label Refactoring on Jan 4, 2020
- MarcoFalke renamed this:
refactor: Remove unused defines in bitcoinunits.h
refactor: Remove unused defines in qt/bitcoinunits.h
on Jan 4, 2020 - MarcoFalke added the label GUI on Jan 4, 2020
-
laanwj commented at 1:56 PM on January 4, 2020: member
I looked at the history of
src/qt/bitcoinunits.hand cannot find when this became unused. Do you know what changed? -
hebasto commented at 2:12 PM on January 4, 2020: member
I looked at the history of
src/qt/bitcoinunits.hand cannot find when this became unused. Do you know what changed?These
#defines were never used. It seems they all are the remnants from the initial version of #4167, I don't know for sure though. -
emilengler commented at 3:38 PM on January 4, 2020: contributor
Just grepped all removed defines.
ACK 7754d7ab1e4f1918fcc31396cd3e7507f936477f
-
promag commented at 11:37 PM on January 4, 2020: member
ACK 7754d7ab1e4f1918fcc31396cd3e7507f936477f.
- fanquake approved
-
fanquake commented at 2:47 AM on January 5, 2020: member
ACK 7754d7ab1e4f1918fcc31396cd3e7507f936477f
These were all introduced in 7007402956579ace12d45cdcfae908802d3d6b6d.
FIGURE_SP_CPwas the only one ever used, but it's use was removed in the following commit 2e4fee2ac4824570c1340a8f8fe2aed4580de879.THIN_SP_CPis defined asREAL_THIN_SP_CPhttps://github.com/bitcoin/bitcoin/blob/593f5e239f277e3fd917737122c2aed3c615430c/src/qt/bitcoinunits.h#L40 - fanquake referenced this in commit da279fe0ee on Jan 5, 2020
- fanquake merged this on Jan 5, 2020
- fanquake closed this on Jan 5, 2020
- sidhujag referenced this in commit 641989f7e7 on Jan 5, 2020
- hebasto deleted the branch on Jan 5, 2020
- MarkLTZ referenced this in commit 8436547baa on Apr 6, 2020
- jasonbcox referenced this in commit 523cfa04d5 on Sep 28, 2020
- sidhujag referenced this in commit ea2d42601c on Nov 10, 2020
- PastaPastaPasta referenced this in commit 13afe1d1d9 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 710f8867a1 on Jun 28, 2021
- PastaPastaPasta referenced this in commit a88d4c81a3 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 7121f0ff41 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 9a4f0fe718 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 0ae0be7338 on Jul 14, 2021
- PastaPastaPasta referenced this in commit bd334da35f on Jul 14, 2021
- PastaPastaPasta referenced this in commit bad56d0ee8 on Jul 15, 2021
- DrahtBot locked this on Feb 15, 2022
