Restore English translation option #17886

1. 
   achow101 commented at 4:00 AM on January 7, 2020: member

   It was reported on Bitcointalk that the normal English language option was lost in 0.19. This PR restores it. For some reason it was removed during the last periodic translation update.

2. Restore English translation option 63bf06afc3
3. fanquake added the label GUI on Jan 7, 2020
4. 
   fanquake commented at 4:06 AM on January 7, 2020: member

   Looks like it was removed in https://github.com/bitcoin/bitcoin/pull/16988/files#diff-97acbf58935ff089c69647a024abce9aL18.

5. fanquake requested review from laanwj on Jan 7, 2020
6. 
   achow101 commented at 4:13 AM on January 7, 2020: member

   Looks like it's probably because the all_ts_files() function in update-translations.py explicitly ignores the bitcoin_en.ts file.

7. 
   laanwj commented at 12:30 PM on January 8, 2020: member

   This was definitely overlooked. These files are auto-generated by update-translations.py, which excludes the English translation. It shouldn't, for that purpose.

8. 
   laanwj commented at 12:36 PM on January 8, 2020: member

   This PR is not strictly needed as the next periodic translation update (with https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/50) will restore the files.

   But maybe it's useful for testing in the mean-time (as there are no translations for master) so ACK 63bf06afc387a9aba7e9933d7970ff88da26dc29

   I will simply do a translations update for the 0.19 branch.

9. laanwj added the label Needs backport (0.19) on Jan 8, 2020
10. laanwj removed the label Needs backport (0.19) on Jan 8, 2020
11. laanwj referenced this in commit fd4ec7c720 on Jan 8, 2020
12. laanwj referenced this in commit 6dd982aa9e on Jan 8, 2020
13. laanwj merged this on Jan 8, 2020
14. laanwj closed this on Jan 8, 2020

    ---

15. MarkLTZ referenced this in commit e5d848cb98 on Jan 12, 2020
16. DrahtBot locked this on Feb 15, 2022

Review Requested
laanwj