qa: Fix double-negative arg test #17893

1. 
   hebasto commented at 10:58 pm on January 7, 2020: member

   Commit 67518f7cc61bf59ddfa0fd7c8dbbdec3653b9556 tests do not catch that a pointer is returned instead of a value.

   This PR makes test to not accept trailing characters after 0.

   From IRC:

   <hebasto> ryanofsky: hmm, why test/functional/feature_config_args.py passed on 67518f7cc61bf59ddfa0fd7c8dbbdec3653b9556 ? <hebasto> I see now: test is broken. <ryanofsky> test should be unaffected by that change, do you see a break somewhere? <hebasto> yes: “-connect=0x7fff50369968” != “-connect=0” … <ryanofsky> Oh I see how that would happen, it should not be a problem in the current PR. <hebasto> going to submit a pr to fix test <ryanofsky> in the commit you mentioned, value is a pointer to a string, and it was printing the pointer address instead of the string on: LogPrintf(“Warning: parsed potentially confusing double-negative -%s=%s\n”, key, value); <hebasto> correct <ryanofsky> oh I see, test could be fixed to more robust and not accept trailing characters after 0

2. qa: Fix double-negative arg test 8b2f471a1b
3. 
   hebasto commented at 10:58 pm on January 7, 2020: member

   ping @ryanofsky
4. fanquake added the label Tests on Jan 7, 2020
5. ryanofsky approved
6. 
   ryanofsky commented at 11:19 pm on January 7, 2020: member

   Code review ACK 8b2f471a1bff753cc4df29805ef38c3623f64f6e. I don’t know how you found this but it’s a nice catch! This change should make the test more reliable.
7. fanquake referenced this in commit f8c69677a1 on Jan 10, 2020
8. fanquake merged this on Jan 10, 2020
9. fanquake closed this on Jan 10, 2020

   ---

10. hebasto deleted the branch on Jan 10, 2020
11. sidhujag referenced this in commit 0688fb8535 on Jan 14, 2020
12. MarkLTZ referenced this in commit 8823f65197 on Apr 7, 2020
13. MarkLTZ referenced this in commit 0a1571d657 on Apr 7, 2020
14. sidhujag referenced this in commit 97e6529a03 on Nov 10, 2020
15. jasonbcox referenced this in commit 19458b9aa1 on Nov 17, 2020
16. PastaPastaPasta referenced this in commit cd3361ebe3 on Jun 27, 2021
17. PastaPastaPasta referenced this in commit 1777e17d2f on Jun 28, 2021
18. PastaPastaPasta referenced this in commit e3419cb00d on Jun 29, 2021
19. PastaPastaPasta referenced this in commit b030aa9de8 on Jul 1, 2021
20. PastaPastaPasta referenced this in commit 56f63b6a58 on Jul 1, 2021
21. PastaPastaPasta referenced this in commit 2846ae1802 on Jul 14, 2021
22. PastaPastaPasta referenced this in commit 27c66197d6 on Jul 14, 2021
23. PastaPastaPasta referenced this in commit 037fa2dd14 on Jul 15, 2021
24. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto ryanofsky

Labels
Tests