depends: Allow building with system clang #17919

pull dongcarl wants to merge 7 commits into bitcoin:master from dongcarl:2020-01-depends-macos-allow-system-clang changing 6 files +121 −27
  1. dongcarl commented at 8:16 pm on January 13, 2020: member

    This replaces: #17099


    This patchset allows us to force depends to use system clang.

    Previously, #17099 removes our dependency on a specific clang we download from llvm.org, but theuni pointed out that since OSX builds are only ever built with a version of clang that is chosen and “blessed” by Apple, it is more likely that the user will encounter problems if they use their system clang. This patchset forces the user to set FORCE_USE_SYSTEM_CLANG=1 in order to use their system clang (when they know what they’re doing)

  2. dongcarl added the label Needs gitian build on Jan 13, 2020
  3. dongcarl removed the label Needs gitian build on Jan 13, 2020
  4. dongcarl added the label Build system on Jan 13, 2020
  5. dongcarl added this to the "PRs" column in a project

  6. DrahtBot commented at 11:48 pm on January 13, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19124 (doc: Document ALLOW_HOST_PACKAGES dependency option by skmcontrib)
    • #18077 (net: Add NAT-PMP port forwarding support by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. MarcoFalke commented at 7:22 pm on February 11, 2020: member
    wen rebase, sir?
  8. MarcoFalke commented at 7:24 pm on February 11, 2020: member

    To give some context, I am still running into issues cross-compiling for mac on non-x86 arch. So I am hoping that this pull improves it for me.

     0Preprocessing native_cctools...
     1-- The C compiler identification is unknown
     2-- The CXX compiler identification is unknown
     3-- The ASM compiler identification is unknown
     4-- Found assembler: /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang
     5-- Check for working C compiler: /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang
     6-- Check for working C compiler: /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang -- broken
     7CMake Error at /usr/share/cmake-3.10/Modules/CMakeTestCCompiler.cmake:52 (message):
     8  The C compiler
     9
    10    "/home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang"
    11
    12  is not able to compile a simple test program.
    13
    14  It fails with the following output:
    15
    16    Change Dir: /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/libtapi/build/CMakeFiles/CMakeTmp
    17    
    18    Run Build Command:"/usr/bin/make" "cmTC_09e5c/fast"
    19    make[1]: Entering directory '/home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/libtapi/build/CMakeFiles/CMakeTmp'
    20    /usr/bin/make -f CMakeFiles/cmTC_09e5c.dir/build.make CMakeFiles/cmTC_09e5c.dir/build
    21    make[2]: Entering directory '/home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/libtapi/build/CMakeFiles/CMakeTmp'
    22    Building C object CMakeFiles/cmTC_09e5c.dir/testCCompiler.c.o
    23    /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang    -o CMakeFiles/cmTC_09e5c.dir/testCCompiler.c.o   -c /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/libtapi/build/CMakeFiles/CMakeTmp/testCCompiler.c
    24    /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang: 1: /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang: ELF: not found
    25    /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang: 2: /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang: @!: not found
    26    /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang: 7: /home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/toolchain/bin/clang: Syntax error: ")" unexpected
    27    CMakeFiles/cmTC_09e5c.dir/build.make:65: recipe for target 'CMakeFiles/cmTC_09e5c.dir/testCCompiler.c.o' failed
    28    make[2]: *** [CMakeFiles/cmTC_09e5c.dir/testCCompiler.c.o] Error 2
    29    make[2]: Leaving directory '/home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/libtapi/build/CMakeFiles/CMakeTmp'
    30    Makefile:126: recipe for target 'cmTC_09e5c/fast' failed
    31    make[1]: *** [cmTC_09e5c/fast] Error 2
    32    make[1]: Leaving directory '/home/travis/build/MarcoFalke/bitcoin-core/depends/work/build/x86_64-apple-darwin16/native_cctools/3764b223c011574971ee3ae09ce968ba5dc2f00f-fb072d1ddcc/libtapi/build/CMakeFiles/CMakeTmp'
    
  9. dongcarl force-pushed on Feb 11, 2020
  10. dongcarl commented at 8:31 pm on February 11, 2020: member
    Rebased over #18072 and updated PR description.
  11. dongcarl commented at 8:51 pm on February 11, 2020: member
    @MarcoFalke This will definitely improve the situation for you (as I think the error you encounter is because we download a clang from llvm.org that’s meant to be run on an x86_64 machine), but not sure if it will solve everything.
  12. dongcarl force-pushed on Jun 8, 2020
  13. dongcarl force-pushed on Jun 10, 2020
  14. dongcarl commented at 8:42 pm on June 10, 2020: member
    Rebased over #19240 and made some simplifications. I think it’s ready for review!
  15. dongcarl marked this as ready for review on Jun 10, 2020
  16. MarcoFalke commented at 11:36 am on June 11, 2020: member
    Looks like travis may be unable to compile mac depends, but the depends stderr is not shown. See #16368 (comment)
  17. dongcarl commented at 3:01 pm on June 11, 2020: member

    Looks like travis may be unable to compile mac depends, but the depends stderr is not shown. See #16368 (comment)

    I think it’s cuz we need the regenerated macOS SDK with the libc++ headers

  18. dongcarl force-pushed on Jun 12, 2020
  19. theuni commented at 8:56 pm on June 12, 2020: member

    Concept ACK and this looks to be in good shape once rebased on top of feedback/fixups in #19240.

    The changes in native_cctools.mk are pretty ugly but straightforward, and current behavior is unchanged as long as FORCE_USE_SYSTEM_CLANG remains unused. Though I think @dongcarl has finally convinced me that we’ll probably move on to system-clang by default at some point and drop our weird pinned one. So hopefully the ugliness is only temporary.

    Well done!

  20. theuni commented at 9:13 pm on June 12, 2020: member
    Travis should be able to find MacOSX10.14-with-libcxx-headers.sdk.tar.gz now :)
  21. dongcarl added the label Needs gitian build on Jun 13, 2020
  22. DrahtBot removed the label Needs gitian build on Jun 14, 2020
  23. fanquake commented at 5:37 am on June 15, 2020: member

    Given that we are going to be using a system Clang, I had a bit of a look into what patching Ubuntu and Guix are doing with their Clang packages to see if there was anything we needed to consider; i.e similar to #18921.

    Guix

    The Clang and LLVM patches are here. They seem fairly mundane. Mostly adjusting include/search paths, and fixing sanitizer build & ABI related issues.

    Ubuntu/Debian

    For Clang 6.0, the most macOS related patch seems to be silent-test-macho.diff. Looks like it deletes one of the tests for llvm-objdump and macho files. Added in this commit. The Clang package doesn’t seem to be modified like GCC, where certain hardening options are defaulted to ON etc.

    For Clang-10, one additional macOS related patch has landed, which removes macOS specific info, i.e -mmacosx-version-min, from the man page. The options still exist in Clang, but seem to have been removed from the manpage just to make it less “Mac-centric”. Added in this commit. Related bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=743133.

  24. dongcarl force-pushed on Jun 15, 2020
  25. DrahtBot added the label Needs rebase on Jun 23, 2020
  26. dongcarl force-pushed on Jun 23, 2020
  27. DrahtBot removed the label Needs rebase on Jun 23, 2020
  28. dongcarl commented at 4:47 pm on June 23, 2020: member

    PR rebased, Gitian build succeeded:

    0- out_manifest: |
    1    7e218500ca12ba66d808041c2bfb46bcc2edfefa9a7d4518bf920f6665e39d73  bitcoin-842e81503b3b-osx-unsigned.dmg
    2    4619e5b8cbf9d09c02a4d10fb1ac0c8d36acb59d42f32ded743f604e66ac9072  bitcoin-842e81503b3b-osx-unsigned.tar.gz
    3    e1f8727102431a6a441b05d14c6fcc3e5b4d7017e709c3744379f8c0187a6e61  bitcoin-842e81503b3b-osx64.tar.gz
    4    f779ba3b880b0a79e6defe5de72dd82a27a3440f13e8144e1849b1e52bd3476a  src/bitcoin-842e81503b3b.tar.gz    
    
  29. dongcarl renamed this:
    depends: Allow building with system clang
    [DO NOT MERGE] depends: Allow building with system clang
    on Jun 23, 2020
  30. MarcoFalke deleted a comment on Jun 24, 2020
  31. laanwj added this to the "Blockers" column in a project

  32. DrahtBot added the label Needs rebase on Jul 3, 2020
  33. depends: Decouple toolchain + binutils
    For now they remain the same, but in the next commit, we will assign
    them differently according to wether or not we're using system clang.
    e6e5c8d6ca
  34. depends: Allow building with system clang c9c572a367
  35. dongcarl force-pushed on Jul 7, 2020
  36. DrahtBot removed the label Needs rebase on Jul 7, 2020
  37. dongcarl commented at 8:53 pm on July 7, 2020: member

    PR rebased again, Gitian build results:

    0- out_manifest: |
    1    98649e59d846ffcd56837b9128a9c4c5bd98684f4c8b6051ebf1f2f4dded4c17  bitcoin-03a7aaab8409-osx-unsigned.dmg
    2    ecbc41ac5b513fb87d802b1167288e1821f60db89359771091770fe8150e5c0c  bitcoin-03a7aaab8409-osx-unsigned.tar.gz
    3    a5d6b02187573e494b3eb1d613082ba6a225a70725c6bb2d332502ab9ccc9ed2  bitcoin-03a7aaab8409-osx64.tar.gz
    4    7728c5ba28edf3e69f764f985628faeb85641970cc34460df44e8a8a1fc32e66  src/bitcoin-03a7aaab8409.tar.gz    
    
  38. MarcoFalke added the label Needs gitian build on Jul 9, 2020
  39. MarcoFalke added the label Needs Guix build on Jul 9, 2020
  40. DrahtBot commented at 8:49 am on July 10, 2020: member

    Guix builds

    File commit e3b31255c5ad8841023231ce843a27789d996ff6(master) commit 65163db57e8b6f55aa458e114436e5a52721fbc6(master and this pull)
    *-aarch64-linux-gnu-debug.tar.gz 28e39cffd299f54d... f15c4f6384d17d5f...
    *-aarch64-linux-gnu.tar.gz 38c922a72ba62298... f943c0578a038c36...
    *-arm-linux-gnueabihf-debug.tar.gz 985f8e5ad20139a7... f3770310a4b90c71...
    *-arm-linux-gnueabihf.tar.gz 68585504e7b5c9aa... 2d03890d3a139711...
    *-riscv64-linux-gnu-debug.tar.gz 922d48eda34530cf... d5b2d3300ec0c14c...
    *-riscv64-linux-gnu.tar.gz 49337fc860c77af3... 18ca07d20f86f3d9...
    *-win-unsigned.tar.gz 87a4575f6a637700... 4f61fa3e554cdfae...
    *-win64-debug.zip 02e7709af6dff129... 7d01f021b98b5835...
    *-win64-setup-unsigned.exe 06400e5d94520e66... e1719d7b6378dc85...
    *-win64.zip 9e2479574fa07c89... 6544d944fbe99904...
    *-x86_64-linux-gnu-debug.tar.gz 0f41b923fa9207d8... d6a13b0c56b3f699...
    *-x86_64-linux-gnu.tar.gz cd2b861d6eba9c1f... d2417fe658732c87...
    *.tar.gz 0b9f378a85934510... a6e04e856ce93b3a...
    guix_build.log a03a41127ae3292a... 556f006e804c4277...
    guix_build.log.diff 069fbe0a6a3bea27...
  41. DrahtBot removed the label Needs Guix build on Jul 10, 2020
  42. theuni commented at 5:09 pm on July 10, 2020: member

    I noticed that this didn’t work with vanilla clang 10 from llvm.org. I’m unsure if there’s some difference in paths, but vanilla clang picks up the libc++ that it’s shipped with over the SDK’s libc++. I suspect that distro-shipped clang’s are patching default paths, which could explain why it works on some systems and not others.

    I was able to fix that like this: https://github.com/theuni/bitcoin/commit/125559aac35f6ad8f6852710d3014379f8d99c4f @dongcarl I think this is the correct fix, and I suspect it might also simplify #17920 for you. Mind having a look and pulling it in if you agree?

  43. dongcarl force-pushed on Jul 10, 2020
  44. dongcarl commented at 9:42 pm on July 10, 2020: member

    Pushed with theuni’s patch and an additional commit explaining our long list of macOS clang options. Although this PR worked before theuni’s patch, the inclusion of this patch makes our depends system more robust on more systems and custom builds of clang, which is great! :relaxed:

    Gitian build results:

    0- out_manifest: |
    1    458cff604e842f65271a82543dc1daffd28f183bbef2fbf8c2b5b076071268d8  bitcoin-01ae3e60a2e0-osx-unsigned.dmg
    2    7b497ff2b1d063433da59c685e87694c5017b2193631f46021ba72f16ce5c246  bitcoin-01ae3e60a2e0-osx-unsigned.tar.gz
    3    ca44784ac6f2bdca293f5709235d5c77661de5605a2a709e5fc5855e89fb1b29  bitcoin-01ae3e60a2e0-osx64.tar.gz
    4    934e8ab0ab7537c7cf111505243740aa3aeb61c10d0487f78611939242123df8  src/bitcoin-01ae3e60a2e0.tar.gz    
    
  45. in depends/Makefile:130 in 01ae3e60a2 outdated
    124@@ -125,6 +125,10 @@ $(host_arch)_$(host_os)_id_string+=$(shell $(host_CXX) --version 2>/dev/null)
    125 $(host_arch)_$(host_os)_id_string+=$(shell $(host_RANLIB) --version 2>/dev/null)
    126 $(host_arch)_$(host_os)_id_string+=$(shell $(host_STRIP) --version 2>/dev/null)
    127 
    128+ifneq ($(strip $(FORCE_USE_SYSTEM_CLANG)),)
    129+$(host_arch)_$(host_os)_id_string+=system_clang
    


    theuni commented at 10:14 pm on July 10, 2020:

    Sorry, I realize this was my commit..

    In testing, I noticed that we need to add this to the build string too. Because for darwin builds it uses the weird trick of compiling the native builds with the downloaded compiler, we need to redo those builds when we go back and forth between system-clang and non.

     0diff --git a/depends/Makefile b/depends/Makefile
     1index b1d929d8dd..2bc5df974a 100644
     2--- a/depends/Makefile
     3+++ b/depends/Makefile
     4@@ -126,6 +126,7 @@ $(host_arch)_$(host_os)_id_string+=$(shell $(host_RANLIB) --version 2>/dev/null)
     5 $(host_arch)_$(host_os)_id_string+=$(shell $(host_STRIP) --version 2>/dev/null)
     6
     7 ifneq ($(strip $(FORCE_USE_SYSTEM_CLANG)),)
     8+build_id_string+=system_clang
     9 $(host_arch)_$(host_os)_id_string+=system_clang
    10 endif
    

    dongcarl commented at 1:08 am on July 11, 2020:
    Added to: 156b604203ef17b2b77ee9dacf15e375c809242a
  46. depends: force a new host id string if FORCE_USE_SYSTEM_CLANG is in use
    This should be caught by the differing clang --version outputs, but because we
    haven't yet extracted our pinned clang, the system one is actually used for the
    version check. That's not a problem because bumping our pinned clang will
    cause a rebuild of everything anyway.
    156b604203
  47. depends: specify libc++ header location for darwin
    For depends builds this was fixed by fbcfcf69, which deleted the conflicting
    headers. When we no longer control the clang installation, we need to ensure
    that the SDK's libc++ headers are used rather than the ones shipped with clang.
    We can do that by turning off the default include path and hard-coding our own.
    This hard-coded path is ok because we control (via SDK packaging) where these
    headers end-up.
    
    Side-note: Now that this path is hard-coded in depends, we can potentially
    package the SDK differently, as the c++ folder can live wherever is most
    convenient for us.
    6b8e497eea
  48. depends: Add justifications for macOS clang flags 60c55b1b9b
  49. depends: Reformat make options as definition list fe98999dcf
  50. depends: Add documentation for FORCE_USE_SYSTEM_CLANG make flag de4fedb6c3
  51. in depends/Makefile:159 in c9c572a367 outdated
    155@@ -156,7 +156,11 @@ $(host_arch)_$(host_os)_native_toolchain?=$($(host_os)_native_toolchain)
    156 include funcs.mk
    157 
    158 binutils_path=$($($(host_arch)_$(host_os)_native_binutils)_prefixbin)
    159+ifeq ($(strip $(FORCE_USE_SYSTEM_CLANG)),)
    


    theuni commented at 10:19 pm on July 10, 2020:
    Please add FORCE_USE_SYSTEM_CLANG to the options in README.md (preferably with an expert disclaimer).

    dongcarl commented at 1:08 am on July 11, 2020:
    See: de4fedb6c3a45e6a23f1bccd28045d76b5830afc
  52. dongcarl force-pushed on Jul 11, 2020
  53. DrahtBot commented at 5:50 am on July 11, 2020: member

    Gitian builds

    File commit a4eb6a51a7f6eb68c35a90436739e0a7d884ed94(master) commit 1605cd7b2a01b31daf5e56bcf6abf69578268c91(master and this pull)
    *-aarch64-linux-gnu-debug.tar.gz ff553bc3ffbee22d... 2d9d2fb6b4538177...
    *-aarch64-linux-gnu.tar.gz e9bc14cd164b581e... 03e83a9e2f8a6d1f...
    *-arm-linux-gnueabihf-debug.tar.gz 26987e40a0e99175... f8ca2da2940db5d1...
    *-arm-linux-gnueabihf.tar.gz 9696e48f5ad65868... 1653c9315dd865af...
    *-osx-unsigned.dmg 081343b68f74e266... bb96ad50a042cb17...
    *-osx64.tar.gz ef9a4288b7b6c736... 8e0f38c85077652e...
    *-riscv64-linux-gnu-debug.tar.gz 29b27eb64963e37f... 80459a36abb6130f...
    *-riscv64-linux-gnu.tar.gz 9ae45a92bfda459d... 0cc0dc77557f73d0...
    *-win64-debug.zip dfb6264beca6bb6b... 6f8d498c981c0a40...
    *-win64-setup-unsigned.exe 50b4eebdccd2fcb9... 0573179dd0e7b2ec...
    *-win64.zip d3457b68644e97ef... c7ab61ef673004b0...
    *-x86_64-linux-gnu-debug.tar.gz 66f6eb4ab461d962... 708afd41ca6e10b8...
    *-x86_64-linux-gnu.tar.gz 2c5b0c13222ffbbb... 3c8aca3b8442cd95...
    *.tar.gz ac3da73abbf1a0fc... 084464debe776247...
    bitcoin-core-linux-0.21-res.yml 240afde1b08adb41... f68676cf76c2abd8...
    bitcoin-core-osx-0.21-res.yml 603a9e87be240d4d... 7587405a2e99f632...
    bitcoin-core-win-0.21-res.yml 45a2f0938a08cd23... f992a11ef8a288a9...
    linux-build.log 0bc39aa61b57f6f4... 2e4f801ec8468e0f...
    osx-build.log 0989405bcb14e851... e7b708e467d1fc35...
    win-build.log 2dc9b4be1e123be5... 3f4a8f52dbecbd4e...
    bitcoin-core-linux-0.21-res.yml.diff 9536ef74eb29883f...
    bitcoin-core-osx-0.21-res.yml.diff b2dee525c4282566...
    bitcoin-core-win-0.21-res.yml.diff 4a85b4a2ccace38e...
    linux-build.log.diff 2d9c374209c885cb...
    osx-build.log.diff 6612e7264f692eda...
    win-build.log.diff a938916a0811e6c9...
  54. DrahtBot removed the label Needs gitian build on Jul 11, 2020
  55. theuni approved
  56. theuni commented at 8:24 pm on July 15, 2020: member

    ACK de4fedb6c3a45e6a23f1bccd28045d76b5830afc.

    I’ve been using this branch for the last week or so, using both external and pinned clang, and all has worked great.

  57. dongcarl force-pushed on Jul 16, 2020
  58. dongcarl renamed this:
    [DO NOT MERGE] depends: Allow building with system clang
    depends: Allow building with system clang
    on Jul 16, 2020
  59. fanquake merged this on Jul 16, 2020
  60. fanquake closed this on Jul 16, 2020

  61. laanwj removed this from the "Blockers" column in a project

  62. sidhujag referenced this in commit 33369338f9 on Jul 18, 2020
  63. fanquake referenced this in commit e0ed4cc50d on Jul 28, 2020
  64. sidhujag referenced this in commit aad54d66aa on Jul 28, 2020
  65. zkbot referenced this in commit 2a39656e6d on Jul 30, 2020
  66. fanquake moved this from the "PRs" to the "Done" column in a project

  67. zkbot referenced this in commit e0692ed4df on Aug 7, 2020
  68. hebasto commented at 2:25 pm on August 15, 2020: member

    @dongcarl

    Multiple warnings observed on Travis macOS 10.12 build: clang: warning: argument unused during compilation: '-nostdinc++' [-Wunused-command-line-argument]

  69. dongcarl commented at 4:29 pm on August 18, 2020: member
    @fanquake You mentioned on IRC that hebasto’s observation was known about. I’m not 100% sure I know what you’re talking about though, is there an open issue?
  70. fanquake commented at 0:53 am on August 19, 2020: member

    I’m not 100% sure I know what you’re talking about though, is there an open issue?

    There’s no issue, but it was discussed offline IIRC. I’ll mention it in #19683, as I think documenting it as part of those changes is probably the easiest thing to do right now.

  71. jasonbcox referenced this in commit f3bc63937c on Oct 6, 2020
  72. furszy referenced this in commit 816f42d7ac on May 25, 2021
  73. kittywhiskers referenced this in commit f10caf16c8 on Jul 15, 2021
  74. kittywhiskers referenced this in commit a4d05c6168 on Jul 15, 2021
  75. kittywhiskers referenced this in commit ab41ecb375 on Jul 20, 2021
  76. kittywhiskers referenced this in commit 47a0997df8 on Jul 20, 2021
  77. kittywhiskers referenced this in commit 443cd23d43 on Jul 20, 2021
  78. kittywhiskers referenced this in commit 20b0b5c270 on Jul 20, 2021
  79. kittywhiskers referenced this in commit 8699b22a1a on Aug 1, 2021
  80. kittywhiskers referenced this in commit 51c3dcefcd on Aug 24, 2021
  81. kittywhiskers referenced this in commit d2804c9326 on Aug 24, 2021
  82. kittywhiskers referenced this in commit 496052d1ed on Aug 25, 2021
  83. kittywhiskers referenced this in commit 02db76ae4d on Aug 25, 2021
  84. kittywhiskers referenced this in commit 465b26ad49 on Aug 26, 2021
  85. kittywhiskers referenced this in commit 5af4b272f3 on Aug 26, 2021
  86. kittywhiskers referenced this in commit d98c35c2c9 on Aug 26, 2021
  87. kittywhiskers referenced this in commit e8c70deb46 on Aug 27, 2021
  88. kittywhiskers referenced this in commit 2e06cc196d on Aug 30, 2021
  89. kittywhiskers referenced this in commit 8f88b3bd2f on Sep 1, 2021
  90. kittywhiskers referenced this in commit 579c4ef05d on Sep 1, 2021
  91. kittywhiskers referenced this in commit 1073143a1c on Sep 1, 2021
  92. kittywhiskers referenced this in commit b655b46c43 on Sep 1, 2021
  93. kittywhiskers referenced this in commit b140c31e1d on Sep 2, 2021
  94. kittywhiskers referenced this in commit 8e13925719 on Sep 3, 2021
  95. kittywhiskers referenced this in commit 6069f6f17e on Sep 3, 2021
  96. kittywhiskers referenced this in commit fd3db69ed8 on Sep 3, 2021
  97. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me