gui: HD icon is displayed when no wallet is loaded #17927

issue fanquake openend this issue on January 15, 2020

fanquake commented at 6:37 am on January 15, 2020: member

Compile master, and run with src/qt/bitcoin-qt -regtest -nowallet. As expected, no icon is displayed. Load and unload a wallet. The HD icon remains.

On startup:

After a wallet load and unload:
fanquake added the label GUI on Jan 15, 2020
fanquake added the label good first issue on Jan 15, 2020
theStack commented at 3:05 pm on January 15, 2020: member

The same behaviour also applies to the encryption icon, if you load a wallet that is encrypted.
brakmic commented at 8:31 pm on January 15, 2020: contributor

I could also show/hide the lock icon the same way I did with HD icon, but I am not sure if this should be packed together in a single PR. It’s actually nothing complex, so it could maybe be better to avoid opening another one only because of an icon.

For now, I have only changed the handling of HD icon.
fanquake commented at 9:57 pm on January 15, 2020: member

but I am not sure if this should be packed together in a single PR. @brakmic Given how simple the changes are here, I think it makes sense to just fix both in the same PR.
promag commented at 10:01 pm on January 15, 2020: member

the same PR.

Agree.
brakmic commented at 10:04 pm on January 15, 2020: contributor

Ok, have updated the PR and renamed it too.
fanquake closed this on Jan 16, 2020
DrahtBot locked this on Feb 15, 2022
Munkybooty referenced this in commit 451216e956 on Jun 25, 2022
Munkybooty referenced this in commit 61355ef19d on Aug 3, 2022
Munkybooty referenced this in commit 592ed6e7dc on Aug 22, 2022
Munkybooty referenced this in commit f7551aa380 on Aug 24, 2022
Munkybooty referenced this in commit 40c48c06ac on Aug 31, 2022
Munkybooty referenced this in commit 07da6f6b92 on Sep 19, 2022
Munkybooty referenced this in commit afa583fb39 on Oct 3, 2022

Contributors
fanquake theStack brakmic promag

Labels
GUI good first issue