gui: Remove warning "unused variable 'wallet_model'" #17939

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2020/01/disable-wallet-unused-variable changing 1 files +1 −5

Sjors commented at 1:29 PM on January 16, 2020: member

This was part of the abandoned #15150.
gui: Remove warning "unused variable 'wallet_model'" c279a81e9c
Sjors requested review from promag on Jan 16, 2020
fanquake added the label Refactoring on Jan 16, 2020
theStack approved
theStack commented at 6:20 PM on January 16, 2020: member

utACK https://github.com/bitcoin/bitcoin/pull/17939/commits/c279a81e9c7dc3386e929ff8b635e7a0de9c20c5 Changes LGTM -- the variable wallet_model is not needed if ENABLE_WALLET is not set and accessing the current element of a combox-box using QComboBox::currentData() instead of using the index is possible since Qt 5.2 (https://doc.qt.io/qt-5/qcombobox.html#currentData-prop).
promag commented at 6:22 PM on January 16, 2020: member

Thanks @Sjors for picking this, ACK.
promag approved
fanquake approved
fanquake commented at 8:00 AM on January 17, 2020: member
ACK c279a81e9c7dc3386e929ff8b635e7a0de9c20c5 - tested wallet loading/unloading in the qt rpc console.

This warning is fixed when compiling with --disable-wallet:
```
qt/rpcconsole.cpp:908:22: warning: unused variable 'wallet_model' [-Wunused-variable]
        WalletModel* wallet_model{nullptr};
                     ^
1 warning generated.
```
fanquake referenced this in commit c20fbb7be8 on Jan 17, 2020
fanquake merged this on Jan 17, 2020
fanquake closed this on Jan 17, 2020
Sjors deleted the branch on Jan 17, 2020
MarkLTZ referenced this in commit 7fdadc73fc on Apr 6, 2020
MarkLTZ referenced this in commit 8436547baa on Apr 6, 2020
Fabcien referenced this in commit 8d55767e3c on Dec 7, 2020
PastaPastaPasta referenced this in commit 81f118f3d3 on Sep 17, 2021
thelazier referenced this in commit 092bb8a134 on Sep 25, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#15150 gui: Show wallet selector on console window if there are wallets loaded