Data-driven tests for CTransaction::CheckTransaction() #1794

pull TheBlueMatt wants to merge 2 commits into bitcoin:master from TheBlueMatt:testdata changing 3 files +67 −4

TheBlueMatt commented at 2:34 AM on September 6, 2012: member

No description provided.

check tx.CheckTransaction for data-driven tx tests.

(and change so that only one case has to fail to make a tx_invalid
test correct)

1fcebc16c5

Add various tests for CTransaction::CheckTransaction() 65786afb05
TheBlueMatt closed this on Sep 6, 2012
TheBlueMatt reopened this on Sep 6, 2012
BitcoinPullTester commented at 10:07 PM on September 6, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/65786afb0571eb197526f8ada8c8372fbc09b451 for binaries and test log.
in src/test/transaction_tests.cpp:None in 65786afb05
```
 142 | @@ -139,8 +143,10 @@
 143 |                      break;
 144 |                  }
 145 |  
 146 | -                BOOST_CHECK_MESSAGE(!VerifyScript(tx.vin[i].scriptSig, mapprevOutScriptPubKeys[tx.vin[i].prevout], tx, i, test[2].get_bool(), 0), strTest);
 147 | +                fValid = VerifyScript(tx.vin[i].scriptSig, mapprevOutScriptPubKeys[tx.vin[i].prevout], tx, i, test[2].get_bool(), 0);
```
laanwj commented at 6:33 AM on September 7, 2012:

Won't the previous value of fValid, coming from either before the loop or the previous iteration, which is not yet BOOST_CHECKED (as far as I can se in this context), get overwritten here?

TheBlueMatt commented at 5:32 PM on September 7, 2012:

fValid is always either true, or this loop breaks (condition for the for loop includes fValid) and goes directly to the boost check.

laanwj commented at 6:03 PM on September 7, 2012:

OK, clear
laanwj commented at 4:19 PM on September 8, 2012: member

ACK
gavinandresen merged this on Sep 18, 2012
gavinandresen closed this on Sep 18, 2012
DrahtBot locked this on Sep 8, 2021

Contributors

TheBlueMatt

BitcoinPullTester

laanwj