qt, refactor: Optimize signal-slot connections logic #17966

1. 
   hebasto commented at 5:41 pm on January 19, 2020: member

   This PR:

   • is a follow up and based on #17937 (update: already merged)
   • implements an idea from #17937 (comment)
   • simplifies WalletFrame class interface
   • as a side effect, removes bitcoingui -> walletframe -> bitcoingui circular dependency
   • is an alternative to #17500
2. hebasto requested review from promag on Jan 19, 2020
3. hebasto closed this on Jan 19, 2020

   ---

4. hebasto reopened this on Jan 19, 2020

   ---

5. DrahtBot added the label GUI on Jan 19, 2020
6. DrahtBot added the label Tests on Jan 19, 2020
7. 
   DrahtBot commented at 9:56 pm on January 19, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18865 (gui: Refactor WalletFrame to extend QStackView by promag)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. Binh0103 approved
9. fanquake removed the label Tests on Jan 20, 2020
10. 
    jonasschnelli commented at 4:10 am on January 20, 2020: contributor

    Nice cleanup. Concept ACK.
11. DrahtBot added the label Needs rebase on Jan 22, 2020
12. hebasto force-pushed on Jan 30, 2020
13. 
    hebasto commented at 6:11 pm on January 30, 2020: member

    Rebased.
14. DrahtBot removed the label Needs rebase on Jan 30, 2020
15. hebasto force-pushed on Feb 1, 2020
16. 
    hebasto commented at 9:18 am on February 1, 2020: member

    Rebased after #17937 and #18036 have been merged.
17. DrahtBot added the label Needs rebase on Feb 4, 2020
18. hebasto force-pushed on Feb 5, 2020
19. 
    hebasto commented at 9:28 pm on February 5, 2020: member

    Rebased after #18060 has been merged.
20. DrahtBot removed the label Needs rebase on Feb 5, 2020
21. DrahtBot added the label Needs rebase on May 29, 2020
22. qt: Move connections from WalletFrame to BitcoinGUI

    This commit does not change behavior.

    acc144528f
23. qt: Do not pass gui to WalletFrame

    This commit does not change behavior. Also it removes
    bitcoingui->walletframe->bitcoingui circular dependency.

    6258512051
24. qt: Do not pass platformStyle to WalletFrame

    This commit does not change behavior.

    dee2986f2f
25. qt: Make path to showModalOverlay slot shorter

    This commit does not change behavior.

    7d7cd84351
26. hebasto force-pushed on May 29, 2020
27. 
    hebasto commented at 11:43 am on May 29, 2020: member

    Rebased 809fd3a6e4952671633a5c193fb5fa0f41837b29 -> 7d7cd84351b6c1637ec40f7546c1aaa16bb55199 (pr17966.04 -> pr17966.05) due to the conflict with #16432.
28. DrahtBot removed the label Needs rebase on May 29, 2020
29. 
    hebasto commented at 8:21 pm on July 6, 2020: member

    @jonasschnelli Mind reviewing this PR?
30. 
    fanquake commented at 1:01 pm on July 9, 2020: member

    There’s a Concept ACK, however no subsequent review after ~6 months and this is purely a gui/qt refactor. I’m going to suggest moving this over to https://github.com/bitcoin-core/gui.
31. fanquake closed this on Jul 9, 2020

    ---

32. hebasto deleted the branch on Jul 10, 2020
33. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto DrahtBot Binh0103 jonasschnelli fanquake

Review Requested
promag

Labels
GUI