gui: followups from #17492 #17979

issue fanquake opened this issue on January 22, 2020
  1. fanquake commented at 12:18 AM on January 22, 2020: member

    From @meshcollider:

    We now have essentially the same code in the bumpfee RPC, in the GUI when drafting a transaction, and now here when bumping in the GUI too. It would be nice to consolidate it a bit. If you want to leave it to a follow-up though I am happy to merge this with the current ACKs.

    From @promag:

    bumpFee should not be in the wallet model - could follow same approach as WalletControllerActivity - because IMO it's wrong to open message boxes (any GUI change) or copy to clipboard from a model class;
    bumpFee should be asynchronous - 1. above would help here - if from the GUI thread we hit cs_main or cs_wallet then that's bad;
    we keep adding nested event loops with QMessageBox helper functions - again 1. would help here.
  2. fanquake added the label GUI on Jan 22, 2020
  3. fanquake closed this on Jan 21, 2022

  4. DrahtBot locked this on Jan 21, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 00:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me