[0.19] Final backports for 0.19.1 #17988

1. 
   fanquake commented at 12:41 AM on January 23, 2020: member

   We're about ready to do a 0.19.1 release; so I've opened this to collect the last remaining backports.

   If there's something that's been missed / or isn't tagged "Needs backport (0.19)" that you think should be, please comment.

   Currently backports:

   • #17887 - bug-fix macos: give free bytes to F_PREALLOCATE
   • #17980 - test: add missing #include to fix compiler errors
2. bug-fix macos: give free bytes to F_PREALLOCATE

   The macos manpage for fcntl (for F_PEOFPOSMODE) states:
   
   > Allocate from the physical end of file.  In this case, fst_length indicates the number of newly allocated bytes desired.
   
   Github-Pull: #17887
   Rebased-From: 75163f4729c10c40d2843da28a8c79ab89193f6a

   c8ad23c529
3. fanquake added the label Backport on Jan 23, 2020
4. fanquake added this to the milestone 0.19.1 on Jan 23, 2020
5. test: add missing #include to fix compiler errors

   Github-Pull: #17980
   Rebased-From: a5a2654bbc43b5c208418872e5d4c0acbadda5de

   daf2fff236
6. 
   laanwj commented at 12:58 PM on January 23, 2020: member

   Do we still want to include #17892 for 0.19.1?

7. 
   kallewoof commented at 1:29 PM on January 23, 2020: member

   @laanwj It is not vital, but its absence does result in a few GBs of wasted space for anyone doing IBD on 0.19. That's for non-pruned nodes only, so it may very well be the case that a few GBs is negligible for a 250 GB datadir. (IMO hell no, but both @Sjors and @MarcoFalke disagree.)

8. 
   laanwj commented at 1:38 PM on January 23, 2020: member

   @kallewoof Thank you! That doesn't seem too bad to me, though if it's virtually ready for merge, and the risk isn't too high it would be good to include. I'll wait for them to weigh in. Let's aim for tagging 0.19.1rc1 after today's meeting.

   Edit: discussion is in #17892 , not here

9. 
   laanwj commented at 7:41 PM on January 23, 2020: member

   ACK daf2fff236f8ebb75c785b33d2dd6dcd3cf86112

10. laanwj referenced this in commit 178a834687 on Jan 23, 2020
11. laanwj merged this on Jan 23, 2020
12. laanwj closed this on Jan 23, 2020

    ---

13. fanquake deleted the branch on Jan 23, 2020
14. MarkLTZ referenced this in commit d99bc96496 on Feb 13, 2020
15. Munkybooty referenced this in commit 2b9bf6c933 on Dec 9, 2021
16. Munkybooty referenced this in commit 5da2a644f8 on Dec 9, 2021
17. Munkybooty referenced this in commit 7ac5a41438 on Dec 9, 2021
18. Munkybooty referenced this in commit 1d79da9e0a on Dec 23, 2021
19. DrahtBot locked this on Feb 15, 2022

Milestone
0.19.1