refactor: Add ChainClient setMockTime, getWallets methods #17999

ryanofsky commented at 10:29 PM on January 24, 2020: member

This PR is part of the process separation project.

These changes are needed to set mock times, and get wallet interface pointers correctly when wallet code is running in a different process from node code in #10102

fanquake added the label Refactoring on Jan 24, 2020

MarcoFalke commented at 4:48 PM on January 25, 2020: member

re-run ci

MarcoFalke closed this on Jan 25, 2020

MarcoFalke reopened this on Jan 25, 2020

in src/interfaces/chain.h:290 in a24758246f outdated

 281 | @@ -280,6 +282,12 @@ class ChainClient
 282 |  
 283 |      //! Shut down client.
 284 |      virtual void stop() = 0;
 285 | +
 286 | +    //! Set mock time.
 287 | +    virtual void setMockTime(int64_t time) = 0;
 288 | +
 289 | +    //! Return interfaces for accessing wallets (if any).
 290 | +    virtual std::vector<std::unique_ptr<Wallet>> getWallets() { return {}; }

promag commented at 4:56 PM on January 27, 2020:

Any reason to have definition?

MarcoFalke commented at 6:29 PM on January 30, 2020:

I presume this is needed when there is more than one chain client that has wallets. Maybe the doc string could be clarified to say "of the wallets of all chain clients" or similar.

ryanofsky commented at 8:03 PM on February 25, 2020:

Any reason to have definition?

No, I think something must have prompted me to add the definition at some point, but I can't think of what that would have been. Removed definition now (thanks)

promag commented at 4:58 PM on January 27, 2020: member

Code review ACK, but could squash and avoid the temporary circular dependency.

MarcoFalke approved

MarcoFalke commented at 6:29 PM on January 30, 2020: member

ACK 06edeb442971747634d1558130d15e6227325422 🚻

<details><summary>Show signature and timestamp</summary>

Signature:

Timestamp of file with hash 7dc65ddc41d7a97c1cc5b926e0f20c04316b6c5b18b17537c4fc59c620d2d263 -

</details>

Add ChainClient setMockTime, getWallets methods

Needed to set mock times, and get wallet interface pointers correctly when
wallet code is running in a different process from node code.

1dde238f2c

refactor: Use psbt forward declaration

Also clean up forward other forward declarations in interfaces/wallet.h with !sort

Original motivation for this change was to fix a circular dependencies lint
error: "interfaces/chain.h -> interfaces/wallet.h -> psbt -> node/transaction
-> node/context -> interfaces/chain.h" from an earlier commit in this PR adding
a "interfaces/chain.h -> interfaces/wallet.h" include. Now, the wallet include
is no longer added, but it is still good to clean up the psbt include for
efficiency, and to sort the forward declarations.

3ce16ad2f9

ryanofsky force-pushed on Feb 25, 2020

ryanofsky commented at 9:14 PM on February 25, 2020: member

Rebased 06edeb442971747634d1558130d15e6227325422 -> 3ce16ad2f91d1e2edc7e7bdc5a19f72aa8c3e739 (pr/ipc-clients.1 -> pr/ipc-clients.2, compare) due to conflict with #18037 and removed extraneous include and method definition.

promag commented at 10:10 PM on February 25, 2020: member

Code review ACK 3ce16ad2f91d1e2edc7e7bdc5a19f72aa8c3e739.

MarcoFalke commented at 2:55 PM on February 26, 2020: member

re-ACK 3ce16ad2f91d1e2edc7e7bdc5a19f72aa8c3e739 🔙

<details><summary>Show signature and timestamp</summary>

Signature:

Timestamp of file with hash d3df18e203f28d9eaeee0acf457efa8312dc6a5a45c7a803a6b0ac74106c450d -

</details>

ryanofsky added this to the "In progress" column in a project

DrahtBot commented at 9:10 AM on March 30, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

MarcoFalke merged this on Apr 10, 2020

MarcoFalke closed this on Apr 10, 2020

ryanofsky moved this from the "In progress" to the "Done" column in a project

sidhujag referenced this in commit cb75c3b555 on Apr 13, 2020

jasonbcox referenced this in commit a4ab5f79f2 on Oct 16, 2020

jasonbcox referenced this in commit f89036cf9d on Oct 16, 2020

PhotoshiNakamoto referenced this in commit bb233e8ba6 on Dec 11, 2021

DrahtBot locked this on Feb 15, 2022