test: rename test suite name "tx_validationcache_tests" to match filename #18010

pull theStack wants to merge 1 commits into bitcoin:master from theStack:20200127-test-adapt-test-suite-names-to-file-names changing 2 files +3 −3

theStack commented at 9:53 PM on January 27, 2020: member

Quoting src/test/README.md, 'Adding test cases':

"The file naming convention is `<source_filename>_tests.cpp`
 and such files should wrap their tests in a test suite
 called `<source_filename>_tests`."

Currently the unit test source file txvalidationcache_tests.cpp contains a unit test suite with the name tx_validationcache_tests, which is fixed by this PR. The following shell script shows that this is the only mismatch and for all other unit test source files the test suite names are correct:

 #!/bin/bash
 shopt -s globstar
 for test_full_filename in **/*_tests.cpp; do
     test_name_file=`basename $test_full_filename .cpp`
     test_name_suite=`sed -n "s/^.*TEST_SUITE(\(.*_tests\).*$/\1/p" $test_full_filename`
     if [ $test_name_file != $test_name_suite ]; then
         echo "TestFilename: $test_name_file != TestSuitname: $test_name_suite"
     fi
 done

test: rename test suite name "tx_validationcache_tests" to match filename

Quoting src/test/README.md, 'Adding test cases':
    "The file naming convention is `<source_filename>_tests.cpp`
     and such files should wrap their tests in a test suite
     called `<source_filename>_tests`."

Currently the unit test source file txvalidationcache_tests.cpp contains a unit
test suite with the name tx_validationcache_tests, which is fixed by this commit.
The following shell script shows that this is the only mismatch and for all other
unit test source files the test suite names are correct:

 #!/bin/bash
 shopt -s globstar
 for test_full_filename in **/*_tests.cpp; do
     test_name_file=`basename $test_full_filename .cpp`
     test_name_suite=`sed -n "s/^.*TEST_SUITE(\(.*_tests\).*$/\1/p" $test_full_filename`
     if [ $test_name_file != $test_name_suite ]; then
         echo "TestFilename: $test_name_file != TestSuitname: $test_name_suite"
     fi
 done

b3c4d9bac6

DrahtBot added the label Scripts and tools on Jan 27, 2020
DrahtBot added the label Tests on Jan 27, 2020
MarcoFalke removed the label Scripts and tools on Jan 27, 2020
practicalswift commented at 11:36 PM on January 27, 2020: contributor

ACK b3c4d9bac6910f6c28f6008c5ca7064a315fd2a5 -- expected naming is better than unexpected naming :)
kristapsk approved
kristapsk commented at 12:19 AM on January 28, 2020: contributor

ACK b3c4d9bac6910f6c28f6008c5ca7064a315fd2a5
fanquake referenced this in commit 2755b2b109 on Jan 28, 2020
fanquake merged this on Jan 28, 2020
fanquake closed this on Jan 28, 2020
theStack deleted the branch on Dec 1, 2020
PastaPastaPasta referenced this in commit 2b151afcc4 on Jun 27, 2021
PastaPastaPasta referenced this in commit f7f2337377 on Jun 28, 2021
PastaPastaPasta referenced this in commit dfcd328e70 on Jun 29, 2021
PastaPastaPasta referenced this in commit 94caff97a4 on Jul 1, 2021
PastaPastaPasta referenced this in commit 10881c3b61 on Jul 1, 2021
PastaPastaPasta referenced this in commit 61c4f953a0 on Jul 14, 2021
PastaPastaPasta referenced this in commit 0fa044fb91 on Jul 14, 2021
PastaPastaPasta referenced this in commit 9a4636d57d on Jul 15, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels