tests: reset default arguments during test setup #18024

issue fanquake opened this issue on January 30, 2020

fanquake commented at 3:16 AM on January 30, 2020: member

Following up to #18018, we can rework the test setup so that default argument are reset/re-parsed as part of the setup for each test.

This can be fixed by parsing the command line arguments when the TestingSetup is constructed. Calling AppInitParameterInteraction will reset them to the default.

As a follow-up it could make sense to normalize argument parsing and have the TestingSetup re-parse the arguments to set them to the default. Though, I suspect that that would be a larger change.
fanquake added the label Tests on Jan 30, 2020
MarcoFalke added the label Brainstorming on Jan 30, 2020
MarcoFalke commented at 12:14 AM on May 7, 2020: member

btw, the args are now parsed to some extent in the test setup, so if someone is interested here, this might be fixable
MarcoFalke commented at 12:15 AM on May 7, 2020: member

Longer term we should remove all globals anyway
MarcoFalke commented at 2:32 PM on August 10, 2022: member

The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.
MarcoFalke closed this on Aug 10, 2022
bitcoin locked this on Aug 10, 2023

Contributors

Labels