psbt_wallet_tests: use unique_ptr for GetSigningProvider #18026

pull ajtowns wants to merge 1 commits into bitcoin:master from ajtowns:202001-getsigningprovider-fix changing 1 files +1 −1
  1. ajtowns commented at 6:13 am on January 30, 2020: member
    #17261 changed GetSigningProvider to return a unique_ptr, but #17156 made psbt_wallet_tests use it as well, and wasn’t correspondingly updated.
  2. psbt_wallet_tests: use unique_ptr for GetSigningProvider 1115ba693b
  3. fanquake added the label Tests on Jan 30, 2020
  4. meshcollider commented at 6:45 am on January 30, 2020: contributor
    Thanks! utACK 1115ba693b6f6e216cd8417aa499fd018a7c016e
  5. fanquake approved
  6. fanquake commented at 7:10 am on January 30, 2020: member
    ACK 1115ba693b6f6e216cd8417aa499fd018a7c016e
  7. fanquake referenced this in commit 44c2400bcc on Jan 30, 2020
  8. fanquake merged this on Jan 30, 2020
  9. fanquake closed this on Jan 30, 2020

  10. achow101 commented at 7:28 am on January 30, 2020: member
    Post merge ACK 1115ba693b6f6e216cd8417aa499fd018a7c016e
  11. promag commented at 8:13 am on January 30, 2020: member

    ACK 1115ba693b6f6e216cd8417aa499fd018a7c016e

    Should this be possible? I though get() or release was needed to get raw pointer.

  12. sanjaykdragon commented at 12:46 pm on February 5, 2020: contributor

    ACK 1115ba6

    Should this be possible? I though get() or release was needed to get raw pointer.

    late reply, but should work fine. Same syntax works for std::optional, * to get .value()

  13. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me