#17261 changed GetSigningProvider to return a unique_ptr, but #17156 made psbt_wallet_tests use it as well, and wasn't correspondingly updated.
psbt_wallet_tests: use unique_ptr for GetSigningProvider #18026
pull ajtowns wants to merge 1 commits into bitcoin:master from ajtowns:202001-getsigningprovider-fix changing 1 files +1 −1-
ajtowns commented at 6:13 AM on January 30, 2020: member
-
psbt_wallet_tests: use unique_ptr for GetSigningProvider 1115ba693b
- fanquake added the label Tests on Jan 30, 2020
-
meshcollider commented at 6:45 AM on January 30, 2020: contributor
Thanks! utACK 1115ba693b6f6e216cd8417aa499fd018a7c016e
- fanquake approved
-
fanquake commented at 7:10 AM on January 30, 2020: member
ACK 1115ba693b6f6e216cd8417aa499fd018a7c016e
- fanquake referenced this in commit 44c2400bcc on Jan 30, 2020
- fanquake merged this on Jan 30, 2020
- fanquake closed this on Jan 30, 2020
-
achow101 commented at 7:28 AM on January 30, 2020: member
Post merge ACK 1115ba693b6f6e216cd8417aa499fd018a7c016e
-
promag commented at 8:13 AM on January 30, 2020: member
ACK 1115ba693b6f6e216cd8417aa499fd018a7c016e
Should this be possible? I though
get()orreleasewas needed to get raw pointer. -
sanjaykdragon commented at 12:46 PM on February 5, 2020: contributor
ACK 1115ba6
Should this be possible? I though
get()orreleasewas needed to get raw pointer.late reply, but should work fine. Same syntax works for std::optional, * to get .value()
- DrahtBot locked this on Feb 15, 2022
Labels