Don’t check for DBUS notification on macOS #18042

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2020/01/mac_dbus changing 1 files +19 −13
  1. jonasschnelli commented at 3:21 pm on January 31, 2020: contributor

    When cross compiling for macOS with depends, we do not compile with dbus.

    Though, bitcoin_qt.m4 checks via pkg-config for a Qt5DBUS.pc on the host. If the host has a qt5_dbus system library (regardless of if the depends qt library set), USE_DBUS gets enabled (but is actually not compiled via depends) leading to compile errors.

    This fixes the error by always avoiding DBUS notification on macOS.

    Another (eventually better) way to fix this would be to avoid detection of host qt pkg-config packages when cross compiling.

  2. jonasschnelli added the label macOS on Jan 31, 2020
  3. jonasschnelli force-pushed on Jan 31, 2020
  4. jonasschnelli force-pushed on Jan 31, 2020
  5. Don't check for DBUS notification on macOS efb5213ad6
  6. jonasschnelli force-pushed on Jan 31, 2020
  7. jonasschnelli commented at 5:54 pm on January 31, 2020: contributor
    Closing in favor of #18045
  8. jonasschnelli closed this on Jan 31, 2020

  9. laanwj referenced this in commit 646f0ada02 on Feb 10, 2020
  10. sidhujag referenced this in commit 47fe769fc5 on Feb 18, 2020
  11. sidhujag referenced this in commit e9ea7cd6e6 on Nov 10, 2020
  12. DrahtBot locked this on Feb 15, 2022


jonasschnelli

Labels
macOS


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me