This is an alternative to #18042:
When cross compiling for macOS with depends, we do not compile with dbus. ... This fixes the error by always avoiding DBUS notification on macOS.
Another (eventually better) way to fix this would be to avoid detection of host qt pkg-config packages when cross compiling.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
No conflicts as of last run.
Looks like it doesn't fix the issue: https://bitcoinbuilds.org/logs/251e6256-d6a5-455e-aed8-e39338fd1882.log (somehow still compiles with USE_DBUS)
Looks like it doesn't fix the issue: https://bitcoinbuilds.org/logs/251e6256-d6a5-455e-aed8-e39338fd1882.log (somehow still compiles with USE_DBUS)
Fixed.
Tested ACK f1b20ea0e9918e1566112a94d8c5360246b7b235 - there is no need to use dbus on macOS
Isn't this just masking the actual issue, which is that configure is finding QtDBus outside of what we've built in depends?
Why are we special casing macOS? Shouldn't this same issue be affecting essentially all targets where we explicitly disable dbus when building qt?
Kinda agree with @fanquake that fixing the pkg-config path for depends builds should be done.
Though this quick fix does also make sense on its own.