build: Do not use QtDBus for macOS builds #18045

1. 
   hebasto commented at 5:17 pm on January 31, 2020: member

   This is an alternative to #18042:

   When cross compiling for macOS with depends, we do not compile with dbus. … This fixes the error by always avoiding DBUS notification on macOS.

   Another (eventually better) way to fix this would be to avoid detection of host qt pkg-config packages when cross compiling.

2. DrahtBot added the label Build system on Jan 31, 2020
3. hebasto force-pushed on Jan 31, 2020
4. 
   DrahtBot commented at 5:55 pm on January 31, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

5. 
   jonasschnelli commented at 5:56 pm on January 31, 2020: contributor

   Looks like it doesn’t fix the issue: https://bitcoinbuilds.org/logs/251e6256-d6a5-455e-aed8-e39338fd1882.log (somehow still compiles with USE_DBUS)
6. build: Do not use QtDBus for macOS builds f1b20ea0e9
7. hebasto force-pushed on Jan 31, 2020
8. 
   hebasto commented at 6:05 pm on January 31, 2020: member

   @jonasschnelli

   Looks like it doesn’t fix the issue: https://bitcoinbuilds.org/logs/251e6256-d6a5-455e-aed8-e39338fd1882.log (somehow still compiles with USE_DBUS)

   Fixed.

9. jonasschnelli approved
10. 
    jonasschnelli commented at 7:48 pm on January 31, 2020: contributor

    Tested ACK f1b20ea0e9918e1566112a94d8c5360246b7b235 - there is no need to use dbus on macOS
11. 
    fanquake commented at 1:28 am on February 1, 2020: member

    Isn’t this just masking the actual issue, which is that configure is finding QtDBus outside of what we’ve built in depends?

    Why are we special casing macOS? Shouldn’t this same issue be affecting essentially all targets where we explicitly disable dbus when building qt?

12. 
    jonasschnelli commented at 7:45 am on February 1, 2020: contributor

    Kinda agree with @fanquake that fixing the pkg-config path for depends builds should be done.

    Though this quick fix does also make sense on its own.

13. 
    hebasto commented at 12:13 pm on February 1, 2020: member

    Closed in favor of #18051.
14. hebasto closed this on Feb 1, 2020

    ---

15. laanwj referenced this in commit 646f0ada02 on Feb 10, 2020
16. sidhujag referenced this in commit 47fe769fc5 on Feb 18, 2020
17. hebasto deleted the branch on Jun 13, 2020
18. sidhujag referenced this in commit e9ea7cd6e6 on Nov 10, 2020
19. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto DrahtBot jonasschnelli fanquake

Labels
Build system