net: reference instead of copy in BlockConnected range loop #18054

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:block-connected-ref-instead-of-copy changing 1 files +1 −1

jonatack commented at 9:30 AM on February 2, 2020: member

Reference elements in range for loop instead of copying them and fix Clang -Wrange-loop-analysis warning introduced in a029e18

net_processing.cpp:1185:25: warning: loop variable 'ptx' of
type 'const std::shared_ptr<const CTransaction>' creates a copy from
type 'const std::shared_ptr<const CTransaction>' [-Wrange-loop-analysis]
        for (const auto ptx : pblock->vtx) {
                        ^
net_processing.cpp:1185:14: note: use reference type
'const std::shared_ptr<const CTransaction> &' to prevent copying
        for (const auto ptx : pblock->vtx) {
             ^~~~~~~~~~~~~~~~
1 warning generated.

net: reference instead of copy in BlockConnected range loop
to fix -Wrange-loop-analysis warning introduced in a029e18
9a299a59cc
fanquake added the label P2P on Feb 2, 2020
MarcoFalke commented at 9:53 AM on February 2, 2020: member

ACK 9a299a59cc8a9ab516e047356c5bc0e93774b557
promag commented at 1:45 PM on February 2, 2020: member

ACK 9a299a59cc8a9ab516e047356c5bc0e93774b557.
elichai approved
elichai commented at 3:16 PM on February 2, 2020: contributor

Compiled with clang 9.0.1, got the same warning which this fix (this is a shared_ptr so copying is somewhat more expensive than a primitive (bumps the ref counter)) ACK 9a299a59cc8a9ab516e047356c5bc0e93774b557
emilengler commented at 3:45 PM on February 2, 2020: contributor

ACK 9a299a5.
Empact commented at 4:40 PM on February 2, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/18054/commits/9a299a59cc8a9ab516e047356c5bc0e93774b557
fanquake referenced this in commit 365c83e6a8 on Feb 3, 2020
fanquake merged this on Feb 3, 2020
fanquake closed this on Feb 3, 2020
jonatack deleted the branch on Feb 3, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels