gui: Drop PeerTableModel dependency to ClientModel #18060

pull promag wants to merge 1 commits into bitcoin:master from promag:2020-02-peertablemodel changing 3 files +2 −7
  1. promag commented at 2:50 pm on February 3, 2020: member
    Class PeerTableModel doesn’t actually depend on ClientModel.
  2. gui: Drop PeerTableModel dependency to ClientModel ff59bcd321
  3. promag commented at 2:51 pm on February 3, 2020: member
    @jonasschnelli don’t know how I’ve missed this simple change in #18036.
  4. hebasto commented at 3:48 pm on February 3, 2020: member
    Concept ACK.
  5. DrahtBot added the label GUI on Feb 3, 2020
  6. DrahtBot added the label Tests on Feb 3, 2020
  7. DrahtBot commented at 4:24 pm on February 3, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18064 (gui: Drop WalletModel dependency to RecentRequestsTableModel by promag)
    • #17966 (qt, refactor: Optimize signal-slot connections logic by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. fanquake removed the label Tests on Feb 3, 2020
  9. hebasto approved
  10. hebasto commented at 7:06 pm on February 3, 2020: member
    ACK ff59bcd3213ef61f2167c0aa60fcaf5afbc20c61, tested on Linux Mint 19.3. No changes in behavior are observed.
  11. fanquake referenced this in commit 02fafdd12c on Feb 4, 2020
  12. fanquake merged this on Feb 4, 2020
  13. fanquake closed this on Feb 4, 2020

  14. MarkLTZ referenced this in commit 7fdadc73fc on Apr 6, 2020
  15. MarkLTZ referenced this in commit 8436547baa on Apr 6, 2020
  16. Fabcien referenced this in commit 972b80d14b on Dec 22, 2020
  17. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me