depends: Use clang for Ubuntu 16.04 #18116

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20200211-clang-ubuntu changing 1 files +3 −3

hebasto commented at 8:20 AM on February 11, 2020: member
Ubuntu 14.04 standard support ended in April 2019. Also downloaded file for 16.04 is smaller:
```
$ ls -1s clang*
336024 clang+llvm-6.0.1-x86_64-linux-gnu-ubuntu-14.04.tar.xz
285980 clang+llvm-6.0.1-x86_64-linux-gnu-ubuntu-16.04.tar.xz
```
depends: Use clang for Ubuntu 16.04 2c7e701315
fanquake added the label Build system on Feb 11, 2020
fanquake commented at 8:28 AM on February 11, 2020: member

I can't remember why off the top of my head, but we stayed with 14.04 on purpose. How have you tested this? What's the difference between the tarballs? Are the builds produced using either Clang identical? If not, what's the difference?
MarcoFalke added the label Needs gitian build on Feb 11, 2020
hebasto commented at 6:35 PM on February 11, 2020: member

@fanquake

I can't remember why off the top of my head, but we stayed with 14.04 on purpose.

I could not find any related discussion, unfortunately.

How have you tested this? What's the difference between the tarballs? Are the builds produced using either Clang identical? If not, what's the difference?

I've made gitian builds against clang-14.04 and clang-16.04 (diff). Resulted *.dmg files are different in size and content. Both *.dmg files run on macOS 10.14 successfully.
hebasto commented at 6:40 PM on February 11, 2020: member

I can't remember why off the top of my head, but we stayed with 14.04 on purpose.

Could it be related to the previous clang version 3.7.1?
DrahtBot removed the label Needs gitian build on Feb 12, 2020
laanwj commented at 4:32 PM on February 12, 2020: member

Using a newer compiler is generally preferable, though, if this isn't urgent, we might as well wait for 18.04 by now :smile:
dongcarl commented at 5:38 PM on February 12, 2020: member

@theuni can describe the rationale better, but I think the main goal is to download a clang that is closest to the clang shipped with Apple's Xcode.
hebasto commented at 12:56 PM on February 13, 2020: member
I can't remember why off the top of my head, but we stayed with 14.04 on purpose.

Could it be related to the previous clang version 3.7.1? @dongcarl @theuni can describe the rationale better, but I think the main goal is to download a clang that is closest to the clang shipped with Apple's Xcode.

For the version 3.7.1 the following ubuntu binaries are available to download:
- 14.04 LTS
- 15.10
It seems the choice of a LTS distro were preferable. And 16.04 LTS was not available for clang 3.7.1.
fanquake commented at 7:52 AM on February 25, 2020: member

Maybe we can revisit this in the future, but I can't really see a reason why we'd change our release compiler now (after it's only just been updated), if the motivation is only "it's newer" and "the tarball is smaller". It's also still unclear what the difference in the compilers and the produced binaries is.
fanquake closed this on Feb 25, 2020
MarcoFalke deleted a comment on Feb 25, 2020
hebasto deleted the branch on Feb 25, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels