Print errors for all cases of SetBestChain and ConnectBlock failing #1813

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:invblk_errs changing 1 files +9 −3

luke-jr commented at 11:31 PM on September 9, 2012: member

No description provided.
Print errors for all cases of SetBestChain and ConnectBlock failing 947309a82f
gavinandresen commented at 3:17 PM on September 10, 2012: contributor

I agree with @gmaxwell, the goto looks like spaghetti code to me.
BitcoinPullTester commented at 11:07 PM on September 10, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/947309a82fe0400e984a56653219c4676416559e for binaries and test log.
jgarzik commented at 7:51 PM on September 18, 2012: contributor

Looks like the consensus of wussy C++ programmers is to NAK the beautiful goto... closing
jgarzik closed this on Sep 18, 2012
luke-jr commented at 9:16 AM on September 20, 2012: member

Please don't close pullreqs just because they need a minor change. The goto has been replaced here.
DrahtBot locked this on Sep 8, 2021

Contributors