build: remove redundant compiler warning suppression #18138

pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:redundant-no-error changing 1 files +0 −3
  1. Bushstar commented at 12:06 PM on February 13, 2020: contributor

    Compiling with GCC 9.2.1 I'm not able to generate a compile time warning with the following compiler flags removed. I wanted to see whether CI has any issues with the following removed. If any problems arise I'll take a look and possibly close this PR, otherwise perhaps we want to remove these flags to prevent the reintroduction of register, self assign or unused local typedef.

    no-self-assign
    no-unused-local-typedef
    no-deprecated-register
    
  2. Bushstar renamed this:
    build: remove redundant compiler error supression
    build: remove redundant compiler warning suppression
    on Feb 13, 2020
  3. fanquake added the label Build system on Feb 13, 2020
  4. build: remove redundant compiler warning suppression 50d7b5c6a4
  5. Bushstar force-pushed on Feb 13, 2020
  6. fanquake commented at 12:22 PM on February 13, 2020: member

    The latest version of GCC isn't the only compiler we need to suppress warnings for. I'm still seeing at least -Wself-assign warnings on macOS with the latest Apple Clang:

    Apple clang version 11.0.0 (clang-1100.0.33.17)
    ...
    test/uint256_tests.cpp:272:7: warning: explicitly assigning value of variable of type 'arith_uint256' to itself [-Wself-assign-overloaded]
        v /= v;
        ~ ^  ~
    test/uint256_tests.cpp:276:7: warning: explicitly assigning value of variable of type 'arith_uint256' to itself [-Wself-assign-overloaded]
        v -= v;
        ~ ^  ~
    2 warnings generated.
    
  7. Bushstar commented at 2:56 PM on February 13, 2020: contributor

    @fanquake closing. I can see lots of warnings in the CI build logs.

  8. Bushstar closed this on Feb 13, 2020

  9. DrahtBot locked this on Feb 15, 2022
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me