Apply BIP30 checks to all blocks except the two historic violations. #1814

1. 
   gmaxwell commented at 12:16 AM on September 10, 2012: contributor

   Matt pointed out some time ago that there existed a minor DOS attack where a node in its initial block download could be wedged by an overwrite attack in a fork created between checkpoints before a time where BIP30 was enforced. Now that the BIP30 timestamp is irreversibly past the check can be more aggressive and apply to all blocks except the two historic violations.

2. Apply BIP30 checks to all blocks except the two historic violations.

   Matt pointed out some time ago that there existed a minor DOS
   attack where a node in its initial block download could be wedged
   by an overwrite attack in a fork created between checkpoints before
   a time where BIP30 was enforced. Now that the BIP30 timestamp
   is irreversibly past the check can be more aggressive and apply to
   all blocks except the two historic violations.

   ab91bf39b7
3. 
   gmaxwell commented at 12:22 AM on September 10, 2012: contributor

   I tested by doing initial block downloads on Bitcoin and testnet. Also tested on bitcoin with each of the hashes broken to make sure it rejected the violators.

4. 
   gavinandresen commented at 3:14 PM on September 10, 2012: contributor

   ACK

5. 
   BitcoinPullTester commented at 7:31 PM on September 10, 2012: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ab91bf39b7c11e9c86bb2043c24f0f377f1cf514 for binaries and test log.

6. 
   Diapolo commented at 8:32 PM on September 10, 2012: none

   What happend to that 2 blocks, which forces you to special-case them? Perhaps an easy answer is possible ;).

7. 
   gmaxwell commented at 8:39 PM on September 10, 2012: contributor

   @Diapolo The miner used an identical pubkey and extranonce, resulting in a duplicate coinbase transaction. (which replaced the prior one, making the earlier one effectively unspendable). This has happened twice... an expensive mistake.

8. 
   laanwj commented at 4:33 PM on September 11, 2012: member

   Great idea, it minimizes the window in which exceptions to the rules are possible.

   ACK

9. 
   sipa commented at 2:20 PM on September 12, 2012: member

   ACK

10. gavinandresen merged this on Sep 12, 2012
11. gavinandresen closed this on Sep 12, 2012

    ---

12. KolbyML referenced this in commit 2018fca21d on Dec 5, 2020
13. KolbyML referenced this in commit c65d0368a0 on Dec 5, 2020
14. DrahtBot locked this on Sep 8, 2021

Milestone
0.7.0