Trivial(qt): Capitalization, spelling #18154

pull yahiheb wants to merge 1 commits into bitcoin:master from yahiheb:qt-nitpicking changing 6 files +9 −9

yahiheb commented at 9:52 PM on February 15, 2020: contributor

Changed: block chain to blockchain synchronisation to synchronization bitcoin to Bitcoin
Trivial(qt): Capitalization, spelling 2de8d6a8ac
DrahtBot added the label GUI on Feb 15, 2020

in src/qt/forms/intro.ui:226 in 2de8d6a8ac

 222 | @@ -223,7 +223,7 @@
 223 |     <item>
 224 |      <widget class="QLabel" name="lblExplanation2">
 225 |       <property name="text">
 226 | -      <string>This initial synchronisation is very demanding, and may expose hardware problems with your computer that had previously gone unnoticed. Each time you run %1, it will continue downloading where it left off.</string>

kristapsk commented at 12:07 AM on February 16, 2020:

"Synchronisation" is just British spelling of American "synchronization", don't see a need for this to be changed.

yahiheb commented at 1:43 AM on February 16, 2020:

Yes, I saw in other places the American spelling was used so I thought it should be changed for consistency.

hebasto commented at 7:29 AM on February 16, 2020: member
@yahiheb Thank you.

May I suggest you two pieces of good reading:
- How to Contribute Pull Requests to Bitcoin Core by @jonatack
- Onboarding to Bitcoin Core by @amitiuttarwar

in src/qt/bitcoingui.cpp:257 in 2de8d6a8ac

 253 | @@ -254,7 +254,7 @@ void BitcoinGUI::createActions()
 254 |      sendCoinsMenuAction->setToolTip(sendCoinsMenuAction->statusTip());
 255 |  
 256 |      receiveCoinsAction = new QAction(platformStyle->SingleColorIcon(":/icons/receiving_addresses"), tr("&Receive"), this);
 257 | -    receiveCoinsAction->setStatusTip(tr("Request payments (generates QR codes and bitcoin: URIs)"));
 258 | +    receiveCoinsAction->setStatusTip(tr("Request payments (generates QR codes and Bitcoin: URIs)"));

fanquake commented at 7:42 AM on February 16, 2020:

There are both meant to be bitcoin:.

yahiheb commented at 3:46 PM on February 16, 2020: contributor
@yahiheb Thank you.

May I suggest you two pieces of good reading:

How to Contribute Pull Requests to Bitcoin Core by @jonatack

Onboarding to Bitcoin Core by @amitiuttarwar @hebasto Thank you. I will definitely take a look at that.
fanquake closed this on Feb 19, 2020
yahiheb commented at 11:29 PM on February 19, 2020: contributor

@fanquake Can I know the reason why this was closed?
jonatack commented at 10:52 AM on February 20, 2020: member

@yahiheb I would venture to guess that it was closed because you are asking for scarce review time for bikeshedding and nitpicking about minutiae (FWIW "block chain" rather than "blockchain" is the preferred spelling in https://github.com/bitcoinops/bitcoinops.github.io/blob/master/STYLE.md). In essence, review is too scarce to be spent for this. I'd suggest looking at the issues tagged as "Good first issues".
yahiheb deleted the branch on Feb 20, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels